From: Mark Brown <broonie@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
alsa-devel@alsa-project.org, devicetree-discuss@lists.ozlabs.org,
Timur Tabi <timur@tabi.org>, Liam Girdwood <lgirdwood@gmail.com>,
Grant Likely <grant.likely@secretlab.ca>,
Sascha Hauer <kernel@pengutronix.de>,
Markus Pargmann <mpa@pengutronix.de>,
Shawn Guo <shawn.guo@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 02/10] ASoC: imx-pcm-dma: DT support
Date: Thu, 18 Apr 2013 15:56:02 +0100 [thread overview]
Message-ID: <20130418145602.GL13687@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <5170069F.4030200@metafoo.de>
[-- Attachment #1.1: Type: text/plain, Size: 650 bytes --]
On Thu, Apr 18, 2013 at 04:43:43PM +0200, Lars-Peter Clausen wrote:
> On 04/18/2013 02:33 PM, Markus Pargmann wrote:
> > + if (pdev->dev.platform_data)
> > + pdev->dev.of_node = pdev->dev.platform_data;
> In my opinion it's better to use pdev->dev.parent->of_node here. In the ssi
> driver you use platform_device_register_data, which will create a copy of
> the of_node you pass in as platform data. I'm not quite sure how well this
> will work. If you want to continue to use platform_data you should at least
> change the code in the ssi driver to not make a copy of the of_node.
If nothing else the above code just looks wrong and confusing.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2013-04-18 14:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-18 12:33 [PATCH v4 00/10] ASoC: fsl-ssi: ac97-slave support Markus Pargmann
2013-04-18 12:33 ` [PATCH v4 05/10] ASoC: fsl-ssi: Use generic DMA bindings if possible Markus Pargmann
[not found] ` <1366288424-7660-1-git-send-email-mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-04-18 12:33 ` [PATCH v4 01/10] ASoC: phycore-ac97: Add DT support Markus Pargmann
2013-04-18 12:33 ` [PATCH v4 02/10] ASoC: imx-pcm-dma: " Markus Pargmann
2013-04-18 14:43 ` Lars-Peter Clausen
2013-04-18 14:56 ` Mark Brown [this message]
[not found] ` <5170069F.4030200-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2013-04-18 15:35 ` [alsa-devel] " Markus Pargmann
2013-04-18 12:33 ` [PATCH v4 03/10] ASoC: imx-pcm-fiq: Introduce pcm-fiq-params Markus Pargmann
2013-04-18 12:33 ` [PATCH v4 04/10] ASoC: fsl-ssi: Add support for imx-pcm-fiq Markus Pargmann
2013-04-18 12:33 ` [PATCH v4 06/10] ARM: imx: Export ac97 reset functions Markus Pargmann
2013-04-18 12:33 ` [PATCH v4 07/10] ASoC: fsl-ssi: imx ac97 support Markus Pargmann
2013-04-18 12:33 ` [PATCH v4 08/10] ASoC: fsl: Kconfig: Use fsl-ssi for phycore-ac97 Markus Pargmann
2013-04-18 12:33 ` [PATCH v4 09/10] ASoC: fsl: Move fsl-ssi binding doc to sound/ Markus Pargmann
2013-04-18 12:33 ` [PATCH v4 10/10] ASoC: fsl: Update fsl-ssi binding doc Markus Pargmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130418145602.GL13687@opensource.wolfsonmicro.com \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=fabio.estevam@freescale.com \
--cc=grant.likely@secretlab.ca \
--cc=kernel@pengutronix.de \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mpa@pengutronix.de \
--cc=shawn.guo@linaro.org \
--cc=timur@tabi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox