From: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, vinod.koul@intel.com,
patches@opensource.wolfsonmicro.com, lgirdwood@gmail.com,
tiwai@suse.de
Subject: Re: [PATCH 1/1] ALSA: compress_core: Ensure device is stopped when stream closed
Date: Fri, 26 Apr 2013 14:56:27 +0100 [thread overview]
Message-ID: <20130426135627.GB27501@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20130426134850.GX5019@opensource.wolfsonmicro.com>
>> + if ((data->stream.runtime->state == SNDRV_PCM_STATE_RUNNING) ||
>> + (data->stream.runtime->state == SNDRV_PCM_STATE_PAUSED))
>> + data->stream.ops->trigger(&data->stream, SNDRV_PCM_TRIGGER_STOP);
>> +
>
>A switch statement would be more idiomatic for this sort of thing.
>
This follows the general style used in other functions in the
source file. I'm happy to upload a version that uses a switch
instead if that's preferred.
next prev parent reply other threads:[~2013-04-26 13:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-26 13:47 [PATCH 1/1] ALSA: compress_core: Ensure device is stopped when stream closed Richard Fitzgerald
2013-04-26 13:48 ` Mark Brown
2013-04-26 13:56 ` Richard Fitzgerald [this message]
2013-04-26 15:38 ` Mark Brown
2013-04-26 16:42 ` Vinod Koul
2013-04-29 9:36 ` Richard Fitzgerald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130426135627.GB27501@opensource.wolfsonmicro.com \
--to=rf@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox