From: Vinod Koul <vinod.koul@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org,
Richard Fitzgerald <rf@opensource.wolfsonmicro.com>,
Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
liam.r.girdwood@intel.com
Subject: Re: [PATCH] ALSA: compress: fix the states to check for allowing read
Date: Mon, 29 Apr 2013 16:24:22 +0530 [thread overview]
Message-ID: <20130429105422.GM24632@intel.com> (raw)
In-Reply-To: <20130429110714.GF5019@opensource.wolfsonmicro.com>
[-- Attachment #1.1: Type: text/plain, Size: 695 bytes --]
On Mon, Apr 29, 2013 at 12:07:14PM +0100, Mark Brown wrote:
> On Sun, Apr 28, 2013 at 01:35:22PM +0530, Vinod Koul wrote:
> > for reading compressed data, we need to allow when we are paused, draining or
> > stopped.
>
> Reviewed-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
>
> > + /* read is allowed when stream is running, paused, draining and setup
> > + * (yes setup is state which we transistion to after stop, so if user
> > + * wants to read data after stop we allow that
> > + */
>
> but I think there's a ) missing in here!
Yup :( I guess since Takshi applied it he can fixup it at end of para, and I
will owe him a beer next time we meet :)
--
~Vinod
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2013-04-29 11:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-28 8:05 [PATCH] ALSA: compress: fix the states to check for allowing read Vinod Koul
2013-04-29 8:55 ` Takashi Iwai
2013-04-29 8:45 ` Vinod Koul
2013-04-29 9:20 ` Takashi Iwai
2013-04-29 8:57 ` Vinod Koul
2013-04-29 9:29 ` Richard Fitzgerald
2013-04-29 9:00 ` Vinod Koul
2013-04-29 11:07 ` Mark Brown
2013-04-29 10:54 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130429105422.GM24632@intel.com \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=liam.r.girdwood@intel.com \
--cc=rf@opensource.wolfsonmicro.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox