From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 3/6] ASoC: ux500: Drop pinctrl sleep support Date: Wed, 8 May 2013 11:51:24 +0100 Message-ID: <20130508105124.GA7478@sirena.org.uk> References: <1367997261-32048-1-git-send-email-fabio.baltieri@linaro.org> <1367997261-32048-4-git-send-email-fabio.baltieri@linaro.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0598233509309083788==" Return-path: Received: from cassiel.sirena.org.uk (cassiel.sirena.org.uk [80.68.93.111]) by alsa0.perex.cz (Postfix) with ESMTP id 5CC0E261658 for ; Wed, 8 May 2013 12:51:39 +0200 (CEST) In-Reply-To: <1367997261-32048-4-git-send-email-fabio.baltieri@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Fabio Baltieri Cc: Ola Lilja , alsa-devel@alsa-project.org, Linus Walleij , Liam Girdwood , linux-kernel@vger.kernel.org, Lee Jones List-Id: alsa-devel@alsa-project.org --===============0598233509309083788== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Jsn5+Lu/ZvzbAGtZ" Content-Disposition: inline --Jsn5+Lu/ZvzbAGtZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 08, 2013 at 09:14:18AM +0200, Fabio Baltieri wrote: > Drop pinctrl default/sleep state switching code, as it was breaking the > capture interface by putting the I2S pins in hi-z mode regardless of its > usage status, and not giving any real benefit. >=20 > Pinctrl default mode configuration is already managed automatically by a > specific pinctrl hog. I tend to agree with Lee that this looks like a bad approach - there's a whole bunch of other code in there which I'd guess is probably equally broken but only the pinctrl code is being removed. Why not just fix it (or better yet simplify all this stuff)? --Jsn5+Lu/ZvzbAGtZ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQIcBAEBAgAGBQJRii4oAAoJELSic+t+oim9KmgP/3UuESUutQ3yJnaQpS4u76AG qbcgcGVV/yCMeqvo5p115+BTy5hcFOYkIL9Js0mRaKX6uXcwYasG/L18AhPY66hF xaYTow7OxQjF8xHpDyH3y36DNKsJHIBL2U9aznXVltk9hIxDFW0lPJpX1bZ71rvS /BvsVW/O9E0sE5NCraplLBnvGA8x7EXC0V6h2nSkT/Qqj+Gl9ceIOPUXkC0H2b7I qPDS34FysNl7JlJj5txK4RDHJe7NIYB+A79syJsOjbGz1mw70Rl28USvixHgU16/ DTLVSAKA8j599ONHDa1C/a9gaIubKomY2WjY7UFz/PpQ5vIjWmEwDKjnG5EjtEz/ uztGZlXi5CONCccX8+HzjF9pMsEcd+Mqou8f+7APNZC7leTgW9v5AouxNEZqTV6r nGPa9cvBtgHjOjEGgwkS0i6PmCDyT8pW5QiQtzwsW95xXqRhkwpolR+BvPN1i8Vw eYF9wj0Yqd7K/VDxhnGalRlS4ETr/drsY+d0CvtpeZQ74zENTVrxTOfu2JIwokpW RdR3i97Dr1vl48aTGmktkjkqoL+hSETu53gndDR3RGELwerCDfjgEUrvFQhQUejT BrpLVN8HFYuwrNsgDPeiccQXVl8Y4NGZ0RycrckhXGIkGwJoCcQoWySh7NkY1s6Y vzu+kaAqOycnRkn4oL91 =dyGU -----END PGP SIGNATURE----- --Jsn5+Lu/ZvzbAGtZ-- --===============0598233509309083788== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============0598233509309083788==--