From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabio Baltieri Subject: Re: [PATCH 6/6] ASoC: ux500: Use the first two AD slots for capture Date: Wed, 8 May 2013 18:08:39 +0200 Message-ID: <20130508160839.GC12970@balto.lan> References: <1367997261-32048-1-git-send-email-fabio.baltieri@linaro.org> <1367997261-32048-7-git-send-email-fabio.baltieri@linaro.org> <20130508105654.GC7478@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20130508105654.GC7478@sirena.org.uk> Sender: linux-kernel-owner@vger.kernel.org To: Mark Brown Cc: Liam Girdwood , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Linus Walleij , Lee Jones , Ola Lilja List-Id: alsa-devel@alsa-project.org On Wed, May 08, 2013 at 11:56:54AM +0100, Mark Brown wrote: > On Wed, May 08, 2013 at 09:14:21AM +0200, Fabio Baltieri wrote: > > Set AD_OUT1 and AD_OUT2, corresponding to LINL and LINR pins, as the > > default input slots for the capture interfaces. > > If these are routing specific analogue inputs to specific timeslots then > this is routing that should be being exposed to DAPM as muxes, not hard > coded in the middle of TDM slot configuration (which is both obscure and > not what the TDM API is there for). The TDM API should be purely about > placing the timeslots for the audio interface on the bus. Ok, it makes sense. Again, this patch was wrote as a fix to the existing codebase to make the driver usable with the actual board available to the community (the snowball). Fabio -- Fabio Baltieri