From: Mark Brown <broonie@kernel.org>
To: Fabio Estevam <fabio.estevam@freescale.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: sgtl5000: Do not read registers prior to turning on the supplies
Date: Tue, 28 May 2013 10:32:55 -0400 [thread overview]
Message-ID: <20130528143255.GK3660@sirena.org.uk> (raw)
In-Reply-To: <1369749858-21579-1-git-send-email-fabio.estevam@freescale.com>
[-- Attachment #1.1: Type: text/plain, Size: 482 bytes --]
On Tue, May 28, 2013 at 11:04:18AM -0300, Fabio Estevam wrote:
> Commit b871f1ad (ASoC: sgtl5000: Read SGTL5000_CHIP_ID in i2c_probe()) placed
> the code for reading the codec revision prior to turning on the power supplies.
>
> Even though this works on some systems that always have the codec power supplies
> enabled, this is not correct, so revert this commit.
It seems like a better fix for this is to just enable the supplies while
doing the device identification?
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2013-05-28 14:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 14:04 [PATCH] ASoC: sgtl5000: Do not read registers prior to turning on the supplies Fabio Estevam
2013-05-28 14:32 ` Mark Brown [this message]
2013-05-30 22:36 ` Marek Vasut
2013-05-31 5:09 ` Estevam Fabio-R49496
2013-05-31 15:32 ` Marek Vasut
2013-05-31 15:36 ` Fabio Estevam
2013-05-31 15:45 ` Marek Vasut
2013-05-31 15:52 ` Fabio Estevam
2013-05-31 17:20 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130528143255.GK3660@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=fabio.estevam@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox