From: Mark Brown <broonie@kernel.org>
To: Marek Vasut <marex@denx.de>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
alsa-devel@alsa-project.org,
Dong Aisheng <dong.aisheng@linaro.org>,
Eric Nelson <eric.nelson@boundarydevices.com>
Subject: Re: [PATCH V2] ASoC: sgtl5000: Fix VAG_POWER enabling/disabling order
Date: Tue, 4 Jun 2013 18:47:14 +0100 [thread overview]
Message-ID: <20130604174714.GS31367@sirena.org.uk> (raw)
In-Reply-To: <1369767356-8496-1-git-send-email-marex@denx.de>
[-- Attachment #1.1: Type: text/plain, Size: 357 bytes --]
On Tue, May 28, 2013 at 08:55:56PM +0200, Marek Vasut wrote:
> The VAG_POWER must be enabled after all other bits in CHIP_ANA_POWER
> and disabled before any other bit in CHIP_ANA_POWER. See the SGTL5000
> datasheet (Table 31, BIT 7, page 42-43). Failing to follow this order
> will result in ugly loud "POP" noise at the end of playback.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2013-06-04 17:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 18:55 [PATCH V2] ASoC: sgtl5000: Fix VAG_POWER enabling/disabling order Marek Vasut
2013-06-04 17:47 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130604174714.GS31367@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=dong.aisheng@linaro.org \
--cc=eric.nelson@boundarydevices.com \
--cc=fabio.estevam@freescale.com \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox