From: Mark Brown <broonie@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Simon <horms@verge.net.au>, Liam Girdwood <lgirdwood@gmail.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
Subject: Re: [PATCH] ASoC: add ak4554 driver
Date: Tue, 2 Jul 2013 01:31:10 +0100 [thread overview]
Message-ID: <20130702003110.GS27646@sirena.org.uk> (raw)
In-Reply-To: <51D1A10D.5000303@metafoo.de>
[-- Attachment #1.1: Type: text/plain, Size: 459 bytes --]
On Mon, Jul 01, 2013 at 05:32:29PM +0200, Lars-Peter Clausen wrote:
> On 07/01/2013 08:43 AM, Kuninori Morimoto wrote:
> > + priv->usrcnt++;
> > + priv->rate = params_rate(params);
> Set the symmetric_rates field of the dai driver to 1 to enforce symmetric
> rates. No need to implement this by hand.
That won't work because there are separate playback and capture DAIs at
the minute. But I think that can be avoided, will comment when I review
tomorrow.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2013-07-02 0:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-01 6:43 [PATCH] ASoC: add ak4554 driver Kuninori Morimoto
2013-07-01 15:32 ` Lars-Peter Clausen
2013-07-02 0:31 ` Mark Brown [this message]
2013-07-02 0:37 ` Kuninori Morimoto
2013-07-02 9:42 ` Mark Brown
2013-07-03 1:39 ` Kuninori Morimoto
2013-07-03 9:18 ` Mark Brown
2013-07-04 4:15 ` [PATCH v2] " Kuninori Morimoto
2013-07-04 10:58 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130702003110.GS27646@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@gmail.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox