From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH] ASoC: kirkwood-i2s: fix a compilation warning Date: Tue, 16 Jul 2013 00:04:29 +0100 Message-ID: <20130715230429.GA24642@n2100.arm.linux.org.uk> References: <20130715103644.04e57749@armhf> <20130715153101.GK11538@sirena.org.uk> <20130715203756.68abbf10@armhf> <20130715200851.GD11538@sirena.org.uk> <20130715213727.GW24642@n2100.arm.linux.org.uk> <20130715225836.GG11538@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20130715225836.GG11538@sirena.org.uk> Sender: linux-kernel-owner@vger.kernel.org To: Mark Brown Cc: Jean-Francois Moine , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Liam Girdwood List-Id: alsa-devel@alsa-project.org On Mon, Jul 15, 2013 at 11:58:36PM +0100, Mark Brown wrote: > The only thing I can see which is pushing a constraint up the stack is > KIRKWOOD_I2S_RATES in the DAIs which only allows 44.1kHz, 48kHz and > 96kHz, the rates for which the internal clock is used. Take a closer look, because you are mistaken. Particularly note how there are two struct snd_soc_dai_driver's, one which gets used if we don't have an external clock, and the other which does. They differ in their .rates initializer.