* [PATCH 21/27] sound/soc/au1x: don't check resource with devm_ioremap_resource
2013-07-23 18:01 [PATCH 00/27] devm cleanup, part #1, take #3 Wolfram Sang
@ 2013-07-23 18:01 ` Wolfram Sang
2013-07-24 14:31 ` Mark Brown
2013-07-23 18:01 ` [PATCH 22/27] sound/soc/cirrus: " Wolfram Sang
` (4 subsequent siblings)
5 siblings, 1 reply; 13+ messages in thread
From: Wolfram Sang @ 2013-07-23 18:01 UTC (permalink / raw)
To: linux-kernel
Cc: Wolfram Sang, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, alsa-devel
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
Please apply via the subsystem-tree.
sound/soc/au1x/psc-ac97.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/sound/soc/au1x/psc-ac97.c b/sound/soc/au1x/psc-ac97.c
index a822ab8..986dcec 100644
--- a/sound/soc/au1x/psc-ac97.c
+++ b/sound/soc/au1x/psc-ac97.c
@@ -379,9 +379,6 @@ static int au1xpsc_ac97_drvprobe(struct platform_device *pdev)
mutex_init(&wd->lock);
iores = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!iores)
- return -ENODEV;
-
wd->mmio = devm_ioremap_resource(&pdev->dev, iores);
if (IS_ERR(wd->mmio))
return PTR_ERR(wd->mmio);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH 21/27] sound/soc/au1x: don't check resource with devm_ioremap_resource
2013-07-23 18:01 ` [PATCH 21/27] sound/soc/au1x: don't check resource with devm_ioremap_resource Wolfram Sang
@ 2013-07-24 14:31 ` Mark Brown
0 siblings, 0 replies; 13+ messages in thread
From: Mark Brown @ 2013-07-24 14:31 UTC (permalink / raw)
To: Wolfram Sang; +Cc: Takashi Iwai, alsa-devel, linux-kernel, Liam Girdwood
[-- Attachment #1.1: Type: text/plain, Size: 189 bytes --]
On Tue, Jul 23, 2013 at 08:01:54PM +0200, Wolfram Sang wrote:
> devm_ioremap_resource does sanity checks on the given resource. No need to
> duplicate this in the driver.
Appiled, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 22/27] sound/soc/cirrus: don't check resource with devm_ioremap_resource
2013-07-23 18:01 [PATCH 00/27] devm cleanup, part #1, take #3 Wolfram Sang
2013-07-23 18:01 ` [PATCH 21/27] sound/soc/au1x: don't check resource with devm_ioremap_resource Wolfram Sang
@ 2013-07-23 18:01 ` Wolfram Sang
2013-07-24 14:33 ` Mark Brown
2013-07-23 18:01 ` [PATCH 23/27] sound/soc/nuc900: " Wolfram Sang
` (3 subsequent siblings)
5 siblings, 1 reply; 13+ messages in thread
From: Wolfram Sang @ 2013-07-23 18:01 UTC (permalink / raw)
To: linux-kernel
Cc: Wolfram Sang, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, alsa-devel
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
Please apply via the subsystem-tree.
sound/soc/cirrus/ep93xx-ac97.c | 3 ---
sound/soc/cirrus/ep93xx-i2s.c | 3 ---
2 files changed, 6 deletions(-)
diff --git a/sound/soc/cirrus/ep93xx-ac97.c b/sound/soc/cirrus/ep93xx-ac97.c
index ac73c60..2a5cdae 100644
--- a/sound/soc/cirrus/ep93xx-ac97.c
+++ b/sound/soc/cirrus/ep93xx-ac97.c
@@ -363,9 +363,6 @@ static int ep93xx_ac97_probe(struct platform_device *pdev)
return -ENOMEM;
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res)
- return -ENODEV;
-
info->regs = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(info->regs))
return PTR_ERR(info->regs);
diff --git a/sound/soc/cirrus/ep93xx-i2s.c b/sound/soc/cirrus/ep93xx-i2s.c
index 17ad70b..f23f331 100644
--- a/sound/soc/cirrus/ep93xx-i2s.c
+++ b/sound/soc/cirrus/ep93xx-i2s.c
@@ -376,9 +376,6 @@ static int ep93xx_i2s_probe(struct platform_device *pdev)
return -ENOMEM;
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res)
- return -ENODEV;
-
info->regs = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(info->regs))
return PTR_ERR(info->regs);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH 22/27] sound/soc/cirrus: don't check resource with devm_ioremap_resource
2013-07-23 18:01 ` [PATCH 22/27] sound/soc/cirrus: " Wolfram Sang
@ 2013-07-24 14:33 ` Mark Brown
0 siblings, 0 replies; 13+ messages in thread
From: Mark Brown @ 2013-07-24 14:33 UTC (permalink / raw)
To: Wolfram Sang; +Cc: Takashi Iwai, alsa-devel, linux-kernel, Liam Girdwood
[-- Attachment #1.1: Type: text/plain, Size: 189 bytes --]
On Tue, Jul 23, 2013 at 08:01:55PM +0200, Wolfram Sang wrote:
> devm_ioremap_resource does sanity checks on the given resource. No need to
> duplicate this in the driver.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 23/27] sound/soc/nuc900: don't check resource with devm_ioremap_resource
2013-07-23 18:01 [PATCH 00/27] devm cleanup, part #1, take #3 Wolfram Sang
2013-07-23 18:01 ` [PATCH 21/27] sound/soc/au1x: don't check resource with devm_ioremap_resource Wolfram Sang
2013-07-23 18:01 ` [PATCH 22/27] sound/soc/cirrus: " Wolfram Sang
@ 2013-07-23 18:01 ` Wolfram Sang
2013-07-24 14:34 ` Mark Brown
2013-07-23 18:01 ` [PATCH 24/27] sound/soc/pxa: " Wolfram Sang
` (2 subsequent siblings)
5 siblings, 1 reply; 13+ messages in thread
From: Wolfram Sang @ 2013-07-23 18:01 UTC (permalink / raw)
To: linux-kernel
Cc: Wolfram Sang, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, alsa-devel
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
Please apply via the subsystem-tree.
sound/soc/nuc900/nuc900-ac97.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/sound/soc/nuc900/nuc900-ac97.c b/sound/soc/nuc900/nuc900-ac97.c
index f4c2417..8987bf9 100644
--- a/sound/soc/nuc900/nuc900-ac97.c
+++ b/sound/soc/nuc900/nuc900-ac97.c
@@ -333,9 +333,6 @@ static int nuc900_ac97_drvprobe(struct platform_device *pdev)
spin_lock_init(&nuc900_audio->lock);
nuc900_audio->res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!nuc900_audio->res)
- return ret;
-
nuc900_audio->mmio = devm_ioremap_resource(&pdev->dev,
nuc900_audio->res);
if (IS_ERR(nuc900_audio->mmio))
--
1.7.10.4
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH 23/27] sound/soc/nuc900: don't check resource with devm_ioremap_resource
2013-07-23 18:01 ` [PATCH 23/27] sound/soc/nuc900: " Wolfram Sang
@ 2013-07-24 14:34 ` Mark Brown
0 siblings, 0 replies; 13+ messages in thread
From: Mark Brown @ 2013-07-24 14:34 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-kernel, Liam Girdwood, Jaroslav Kysela, Takashi Iwai,
alsa-devel
[-- Attachment #1: Type: text/plain, Size: 189 bytes --]
On Tue, Jul 23, 2013 at 08:01:56PM +0200, Wolfram Sang wrote:
> devm_ioremap_resource does sanity checks on the given resource. No need to
> duplicate this in the driver.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 24/27] sound/soc/pxa: don't check resource with devm_ioremap_resource
2013-07-23 18:01 [PATCH 00/27] devm cleanup, part #1, take #3 Wolfram Sang
` (2 preceding siblings ...)
2013-07-23 18:01 ` [PATCH 23/27] sound/soc/nuc900: " Wolfram Sang
@ 2013-07-23 18:01 ` Wolfram Sang
2013-07-24 14:35 ` Mark Brown
2013-07-23 18:01 ` [PATCH 25/27] sound/soc/tegra: " Wolfram Sang
2013-07-23 18:01 ` [PATCH 26/27] sound/soc/txx9: " Wolfram Sang
5 siblings, 1 reply; 13+ messages in thread
From: Wolfram Sang @ 2013-07-23 18:01 UTC (permalink / raw)
To: linux-kernel
Cc: Wolfram Sang, Eric Miao, Russell King, Haojian Zhuang,
Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
linux-arm-kernel, alsa-devel
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
Please apply via the subsystem-tree.
sound/soc/pxa/mmp-sspa.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/sound/soc/pxa/mmp-sspa.c b/sound/soc/pxa/mmp-sspa.c
index 62142ce..1605934 100644
--- a/sound/soc/pxa/mmp-sspa.c
+++ b/sound/soc/pxa/mmp-sspa.c
@@ -430,9 +430,6 @@ static int asoc_mmp_sspa_probe(struct platform_device *pdev)
return -ENOMEM;
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (res == NULL)
- return -ENOMEM;
-
priv->sspa->mmio_base = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(priv->sspa->mmio_base))
return PTR_ERR(priv->sspa->mmio_base);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH 24/27] sound/soc/pxa: don't check resource with devm_ioremap_resource
2013-07-23 18:01 ` [PATCH 24/27] sound/soc/pxa: " Wolfram Sang
@ 2013-07-24 14:35 ` Mark Brown
0 siblings, 0 replies; 13+ messages in thread
From: Mark Brown @ 2013-07-24 14:35 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-kernel, Eric Miao, Russell King, Haojian Zhuang,
Liam Girdwood, Jaroslav Kysela, Takashi Iwai, linux-arm-kernel,
alsa-devel
[-- Attachment #1: Type: text/plain, Size: 189 bytes --]
On Tue, Jul 23, 2013 at 08:01:57PM +0200, Wolfram Sang wrote:
> devm_ioremap_resource does sanity checks on the given resource. No need to
> duplicate this in the driver.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 25/27] sound/soc/tegra: don't check resource with devm_ioremap_resource
2013-07-23 18:01 [PATCH 00/27] devm cleanup, part #1, take #3 Wolfram Sang
` (3 preceding siblings ...)
2013-07-23 18:01 ` [PATCH 24/27] sound/soc/pxa: " Wolfram Sang
@ 2013-07-23 18:01 ` Wolfram Sang
2013-07-24 14:37 ` Mark Brown
2013-07-23 18:01 ` [PATCH 26/27] sound/soc/txx9: " Wolfram Sang
5 siblings, 1 reply; 13+ messages in thread
From: Wolfram Sang @ 2013-07-23 18:01 UTC (permalink / raw)
To: linux-kernel
Cc: Wolfram Sang, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Stephen Warren, alsa-devel, linux-tegra
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
Please apply via the subsystem-tree.
sound/soc/tegra/tegra20_ac97.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/sound/soc/tegra/tegra20_ac97.c b/sound/soc/tegra/tegra20_ac97.c
index e58233f..ef3d0e0 100644
--- a/sound/soc/tegra/tegra20_ac97.c
+++ b/sound/soc/tegra/tegra20_ac97.c
@@ -334,12 +334,6 @@ static int tegra20_ac97_platform_probe(struct platform_device *pdev)
}
mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!mem) {
- dev_err(&pdev->dev, "No memory resource\n");
- ret = -ENODEV;
- goto err_clk_put;
- }
-
regs = devm_ioremap_resource(&pdev->dev, mem);
if (IS_ERR(regs)) {
ret = PTR_ERR(regs);
@@ -432,7 +426,6 @@ static int tegra20_ac97_platform_probe(struct platform_device *pdev)
return 0;
-err_unregister_pcm:
tegra_pcm_platform_unregister(&pdev->dev);
err_unregister_component:
snd_soc_unregister_component(&pdev->dev);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH 25/27] sound/soc/tegra: don't check resource with devm_ioremap_resource
2013-07-23 18:01 ` [PATCH 25/27] sound/soc/tegra: " Wolfram Sang
@ 2013-07-24 14:37 ` Mark Brown
0 siblings, 0 replies; 13+ messages in thread
From: Mark Brown @ 2013-07-24 14:37 UTC (permalink / raw)
To: Wolfram Sang
Cc: alsa-devel, Stephen Warren, Takashi Iwai, Liam Girdwood,
linux-kernel, linux-tegra
[-- Attachment #1.1: Type: text/plain, Size: 259 bytes --]
On Tue, Jul 23, 2013 at 08:01:58PM +0200, Wolfram Sang wrote:
> devm_ioremap_resource does sanity checks on the given resource. No need to
> duplicate this in the driver.
This doesn't seem to apply against my current branch, can you please
check and resend?
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 26/27] sound/soc/txx9: don't check resource with devm_ioremap_resource
2013-07-23 18:01 [PATCH 00/27] devm cleanup, part #1, take #3 Wolfram Sang
` (4 preceding siblings ...)
2013-07-23 18:01 ` [PATCH 25/27] sound/soc/tegra: " Wolfram Sang
@ 2013-07-23 18:01 ` Wolfram Sang
2013-07-24 14:37 ` Mark Brown
5 siblings, 1 reply; 13+ messages in thread
From: Wolfram Sang @ 2013-07-23 18:01 UTC (permalink / raw)
To: linux-kernel
Cc: Wolfram Sang, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, alsa-devel
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
Please apply via the subsystem-tree.
sound/soc/txx9/txx9aclc-ac97.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/sound/soc/txx9/txx9aclc-ac97.c b/sound/soc/txx9/txx9aclc-ac97.c
index 4bcce8a..e0305a1 100644
--- a/sound/soc/txx9/txx9aclc-ac97.c
+++ b/sound/soc/txx9/txx9aclc-ac97.c
@@ -184,9 +184,6 @@ static int txx9aclc_ac97_dev_probe(struct platform_device *pdev)
if (irq < 0)
return irq;
r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!r)
- return -EBUSY;
-
drvdata->base = devm_ioremap_resource(&pdev->dev, r);
if (IS_ERR(drvdata->base))
return PTR_ERR(drvdata->base);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH 26/27] sound/soc/txx9: don't check resource with devm_ioremap_resource
2013-07-23 18:01 ` [PATCH 26/27] sound/soc/txx9: " Wolfram Sang
@ 2013-07-24 14:37 ` Mark Brown
0 siblings, 0 replies; 13+ messages in thread
From: Mark Brown @ 2013-07-24 14:37 UTC (permalink / raw)
To: Wolfram Sang; +Cc: Takashi Iwai, alsa-devel, linux-kernel, Liam Girdwood
[-- Attachment #1.1: Type: text/plain, Size: 189 bytes --]
On Tue, Jul 23, 2013 at 08:01:59PM +0200, Wolfram Sang wrote:
> devm_ioremap_resource does sanity checks on the given resource. No need to
> duplicate this in the driver.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread