From: Mark Brown <broonie@kernel.org>
To: Bard Liao <bardliao@realtek.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Stephen Warren <swarren@wwwdotorg.org>
Subject: Re: Broken headphone and speaker amplifier suppliesforthe rt5640 driver
Date: Mon, 29 Jul 2013 07:07:16 +0100 [thread overview]
Message-ID: <20130729060716.GQ9858@sirena.org.uk> (raw)
In-Reply-To: <1121E117AD4ECE49880A389A396215BB935C48A592@rtitmbs7.realtek.com.tw>
[-- Attachment #1.1: Type: text/plain, Size: 709 bytes --]
On Mon, Jul 29, 2013 at 11:04:46AM +0800, Bard Liao wrote:
> The mute/unmute control is written in rt5640_snd_controls[] now.
> It allows user to unmute speaker or headphone before dapm power on the related power.
> And it will bring a pop noise.
> So I prefer to do the unmute/mute step in the widget event.
> Is that ok?
If you need to do that you should really still present the mute control
to the user; store the current state in a variable in the private data
so that the user always sees the control and then only write the value
out while the widget is powered. Mute is expected to be fast and some
userspaces like to be able to mute individual outputs.
Ideally the core would be able to do this.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2013-07-29 6:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 15:06 Broken headphone and speaker amplifier supplies for the rt5640 driver Lars-Peter Clausen
2013-07-26 16:57 ` Stephen Warren
2013-07-27 17:35 ` Mark Brown
2013-07-29 3:04 ` Broken headphone and speaker amplifier suppliesforthe " Bard Liao
2013-07-29 6:07 ` Mark Brown [this message]
2013-07-29 6:14 ` Lars-Peter Clausen
2013-07-29 6:45 ` Mark Brown
[not found] ` <201307290148.r6T1mLk1013980@rtits1.realtek.com>
2013-07-29 2:48 ` Bard Liao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130729060716.GQ9858@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=lars@metafoo.de \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox