From: Vinod Koul <vinod.koul@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, linaro-kernel@lists.linaro.org,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@linaro.org>
Subject: Re: [PATCH] ASoC: compress: Use power efficient workqueue
Date: Mon, 12 Aug 2013 09:26:38 +0530 [thread overview]
Message-ID: <20130812035638.GT29095@intel.com> (raw)
In-Reply-To: <1376068931-15520-1-git-send-email-broonie@kernel.org>
On Fri, Aug 09, 2013 at 06:22:11PM +0100, Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
>
> There is no need for the power down work to be done on a per CPU workqueue
> especially considering the fairly long delay before powerdown.
>
> Signed-off-by: Mark Brown <broonie@linaro.org>
Acked-by: Vinod Koul <vinod.koul@intel.com>
Thanks
~Vinod
> ---
> sound/soc/soc-compress.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/soc-compress.c b/sound/soc/soc-compress.c
> index d220150..53c9ecd 100644
> --- a/sound/soc/soc-compress.c
> +++ b/sound/soc/soc-compress.c
> @@ -149,8 +149,9 @@ static int soc_compr_free(struct snd_compr_stream *cstream)
> SND_SOC_DAPM_STREAM_STOP);
> } else {
> rtd->pop_wait = 1;
> - schedule_delayed_work(&rtd->delayed_work,
> - msecs_to_jiffies(rtd->pmdown_time));
> + queue_delayed_work(system_power_efficient_wq,
> + &rtd->delayed_work,
> + msecs_to_jiffies(rtd->pmdown_time));
> }
> } else {
> /* capture streams can be powered down now */
> --
> 1.8.4.rc1
>
--
prev parent reply other threads:[~2013-08-12 4:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 17:22 [PATCH] ASoC: compress: Use power efficient workqueue Mark Brown
2013-08-12 3:56 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130812035638.GT29095@intel.com \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=broonie@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linaro-kernel@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox