Re: [PATCH 9/9] ALSA: compress: use rate values for passing sampling rates

[Vinod Koul <vinod.koul@intel.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1120 bytes --]

On Tue, Aug 27, 2013 at 02:29:59PM +0100, Mark Brown wrote:
> On Tue, Aug 27, 2013 at 12:10:39PM +0530, Vinod Koul wrote:
> > Clarify that its better to use the rate values like 8000, 12000, 11025, 44100,
> > 48000 etc to send sampling rate values to driver. The changes kernel ABI but no
> > drivers exist upstream so okay to change now
> > Tinycompress to be fixed as well
> 
> > - * @sampling_rate: sampling rate of audio
> > + * @sampling_rate: sampling rate value of audio,  eg 12000, 48000
> 
> It's not clear why this is a change in the ABI - the values written and
> the types don't change.  Personally I'd not change the ABI - it's a bit
> late now that the code has been in the kernel for several releases.
the problem is the meaning of sampling_rate. It was SND_PCM_RATE_XXX. It was a
lack of foresight on my side, we should have done values which we are changing
now to handle rates not defined here.

But since none of drivers are upstream, impact is IMO managble. I was planning
to communicate this along with tinycompress fixes to all folks who i know are
using this :)

~Vinod
-- 

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]