From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Liam Girdwood <lgirdwood@gmail.com>
Cc: Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Takashi Iwai <tiwai@suse.de>,
alsa-devel <alsa-devel@alsa-project.org>,
Mark Brown <broonie@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RFC 10/13] ASoC: kirkwood-t5325: add DAPM links between codec and cpu DAI
Date: Fri, 30 Aug 2013 17:10:05 +0100 [thread overview]
Message-ID: <20130830161005.GZ6617@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20130830112705.GU6617@n2100.arm.linux.org.uk>
On Fri, Aug 30, 2013 at 12:27:05PM +0100, Russell King - ARM Linux wrote:
> 1. The combining of the CPU and platform code(s) under one device is
> absolutely no problem for ASoC, there's multiple drivers which do this
> already. While this is a true statement, it creates the bug at the
> heart of this thread - and the bug _occuring_ has nothing to do with
> DPCM. The bug is caused solely by the combining of the two components.
Right, having gone back and looked at this in-depth again, and tried some
experiments, I no longer need this problem fixed for the non-DPCM code
to work, but I do still need to do this:
> 4. By adding the AIFs and routes, I'm bypassing/abusing the ASoC DAI core.
> If this were to be the case, why does your DPCM driver set them up.
> Therefore, my conclusion is that Mark was wrong about this too. Yes,
> it may be that for the time being it's not that appealing, because as
> DPCM doesn't work in mainline, I'm unable to separate the DAI link
> between the CPU and the Codec. That doesn't make the creation of
> the routes any more wrong when they're the exact same routes which
> need to be created for DPCM - especially when they're relied upon for
> there to be any audio output what so ever from the driver.
so I can detect which output paths to enable. I will be posting updated
patches shortly, which will just be those which Mark hasn't taken yet.
next prev parent reply other threads:[~2013-08-30 16:10 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-04 19:21 [PATCH RFC 00/13] Adding SPDIF support to kirkwood-i2s Russell King - ARM Linux
2013-08-04 19:22 ` [PATCH RFC 01/13] ASoC: kirkwood: merge struct kirkwood_dma_priv with struct kirkwood_dma_data Russell King
2013-08-05 14:49 ` Mark Brown
2013-08-04 19:23 ` [PATCH RFC 02/13] ASoC: kirkwood: use devm_clk_get() for the external clock Russell King
2013-08-05 16:16 ` Mark Brown
2013-08-04 19:24 ` [PATCH RFC 03/13] ASoC: avoid duplicated DAI routes Russell King
2013-08-05 16:18 ` Mark Brown
2013-08-04 19:25 ` [PATCH RFC 04/13] ASoC: HACK: avoid creating duplicated widgets Russell King
2013-08-04 19:26 ` [PATCH RFC 05/13] ASoC: kirkwood: provide KIRKWOOD_PLAYCTL_ENABLE_MASK Russell King
2013-08-05 17:03 ` Mark Brown
2013-08-04 19:27 ` [PATCH RFC 06/13] ASoC: kirkwood: combine kirkwood-i2s and kirkwood-dma drivers Russell King
2013-08-05 10:13 ` Jean-Francois Moine
2013-08-05 10:20 ` Russell King - ARM Linux
2013-08-05 17:04 ` Mark Brown
2013-08-04 19:28 ` [PATCH RFC 07/13] ASoC: kirkwood: move calculation of max buffer size to kirkwood.h Russell King
2013-08-05 17:07 ` Mark Brown
2013-08-04 19:29 ` [PATCH RFC 08/13] ASoC: kirkwood: add DAPM widgets for input and output routing Russell King
2013-08-04 19:30 ` [PATCH RFC 09/13] ASoC: kirkwood-openrd: add DAPM links between codec and cpu DAI Russell King
2013-08-04 19:31 ` [PATCH RFC 10/13] ASoC: kirkwood-t5325: " Russell King
2013-08-05 11:27 ` Mark Brown
2013-08-05 11:33 ` Russell King - ARM Linux
2013-08-05 14:40 ` Mark Brown
2013-08-05 14:56 ` Russell King - ARM Linux
2013-08-05 20:32 ` Russell King - ARM Linux
2013-08-05 22:06 ` Mark Brown
2013-08-05 23:30 ` Russell King - ARM Linux
2013-08-06 13:32 ` Mark Brown
2013-08-10 16:11 ` Russell King - ARM Linux
2013-08-10 21:13 ` Russell King - ARM Linux
2013-08-12 7:40 ` Liam Girdwood
2013-08-12 8:28 ` Russell King - ARM Linux
2013-08-13 14:59 ` Liam Girdwood
2013-08-20 10:25 ` Russell King - ARM Linux
2013-08-20 11:44 ` Mark Brown
2013-08-20 11:49 ` Russell King - ARM Linux
2013-08-20 13:31 ` Russell King - ARM Linux
2013-08-20 18:50 ` Mark Brown
2013-08-20 20:18 ` Russell King - ARM Linux
2013-08-22 19:22 ` Liam Girdwood
2013-08-22 20:16 ` Russell King - ARM Linux
2013-08-23 12:13 ` Liam Girdwood
2013-08-23 12:58 ` Russell King - ARM Linux
2013-08-23 16:58 ` Mark Brown
2013-08-23 17:45 ` Russell King - ARM Linux
2013-08-28 1:22 ` Mark Brown
2013-08-29 21:12 ` Liam Girdwood
2013-08-30 11:27 ` Russell King - ARM Linux
2013-08-30 16:10 ` Russell King - ARM Linux [this message]
2013-08-11 12:36 ` Mark Brown
2013-08-04 19:32 ` [PATCH RFC 11/13] ASoC: spdif_transceiver: add output pin widget Russell King
2013-08-05 11:33 ` Mark Brown
2013-08-04 19:33 ` [PATCH RFC 12/13] ASoC: kirkwood: add SPDIF output support Russell King
2013-08-04 19:34 ` [PATCH RFC 13/13] ASoC: kirkwood: add IEC958 channel status support Russell King
2013-08-04 21:45 ` [PATCH RFC 00/13] Adding SPDIF support to kirkwood-i2s Sebastian Hesselbarth
2013-08-05 8:43 ` Thomas Petazzoni
2013-08-05 8:53 ` Russell King - ARM Linux
2013-08-05 9:06 ` Thomas Petazzoni
2013-08-05 11:59 ` Mark Brown
2013-08-05 13:06 ` Sebastian Hesselbarth
2013-08-05 14:07 ` Mark Brown
2013-08-05 15:04 ` Sebastian Hesselbarth
2013-08-05 16:59 ` Mark Brown
2013-08-05 18:14 ` Sebastian Hesselbarth
2013-08-05 18:59 ` Mark Brown
2013-08-05 22:47 ` Stephen Warren
2013-08-05 14:10 ` Lars-Peter Clausen
2013-08-05 15:03 ` Mark Brown
2013-08-06 0:02 ` Kuninori Morimoto
2013-08-30 7:20 ` Kuninori Morimoto
2013-08-30 8:26 ` Lars-Peter Clausen
2013-08-30 9:56 ` Mark Brown
2013-08-05 14:59 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130830161005.GZ6617@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).