* [PATCH] ASoC: SAMSUNG: Allow mono in i2s driver
@ 2013-09-11 14:27 Charles Keepax
2013-09-13 10:33 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Charles Keepax @ 2013-09-11 14:27 UTC (permalink / raw)
To: kgene.kim, broonie
Cc: alsa-devel, linux-samsung-soc, patches, lgirdwood, ben-linux,
Charles Keepax
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
I can't see any reason to not allow mono playback in the
i2s driver and indeed it seems to work well on our test
system here. However, I am fairly unfamilar with the code
in this part of the tree so apologies if I am missing some
constraint.
Thanks,
Charles
sound/soc/samsung/i2s.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c
index 959c702..70d08d7 100644
--- a/sound/soc/samsung/i2s.c
+++ b/sound/soc/samsung/i2s.c
@@ -991,7 +991,7 @@ static struct i2s_dai *i2s_alloc_dai(struct platform_device *pdev, bool sec)
i2s->i2s_dai_drv.ops = &samsung_i2s_dai_ops;
i2s->i2s_dai_drv.suspend = i2s_suspend;
i2s->i2s_dai_drv.resume = i2s_resume;
- i2s->i2s_dai_drv.playback.channels_min = 2;
+ i2s->i2s_dai_drv.playback.channels_min = 1;
i2s->i2s_dai_drv.playback.channels_max = 2;
i2s->i2s_dai_drv.playback.rates = SAMSUNG_I2S_RATES;
i2s->i2s_dai_drv.playback.formats = SAMSUNG_I2S_FMTS;
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: SAMSUNG: Allow mono in i2s driver
2013-09-11 14:27 [PATCH] ASoC: SAMSUNG: Allow mono in i2s driver Charles Keepax
@ 2013-09-13 10:33 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2013-09-13 10:33 UTC (permalink / raw)
To: Charles Keepax
Cc: kgene.kim, ben-linux, lgirdwood, linux-samsung-soc, alsa-devel,
patches
[-- Attachment #1: Type: text/plain, Size: 205 bytes --]
On Wed, Sep 11, 2013 at 03:27:29PM +0100, Charles Keepax wrote:
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
APPLIED, THANKS. Please also remember to CC maintainers on patches.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-13 10:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-11 14:27 [PATCH] ASoC: SAMSUNG: Allow mono in i2s driver Charles Keepax
2013-09-13 10:33 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).