From: Vinod Koul <vinod.koul@intel.com>
To: Liam Girdwood <liam.r.girdwood@linux.jf.intel.com>
Cc: Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH] ALSA: compress: Fix compress device unregister.
Date: Mon, 16 Sep 2013 09:45:01 +0530 [thread overview]
Message-ID: <20130916041501.GK17188@intel.com> (raw)
In-Reply-To: <1379090597-7096-2-git-send-email-liam.r.girdwood@linux.intel.com>
On Fri, Sep 13, 2013 at 05:43:17PM +0100, Liam Girdwood wrote:
> snd_unregister_device() should return the device type and not stream
> direction.
Thanks for fixing this, I saw this but didnt get time to fix it.
Acked-By: Vinod Koul <vinod.koul@intel.com>
Tested-By: Vinod Koul <vinod.koul@intel.com>
Is there a Tested-Acked-??
~Vinod
>
> Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
> ---
> sound/core/compress_offload.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c
> index a9ae4f3..fba7e7a 100644
> --- a/sound/core/compress_offload.c
> +++ b/sound/core/compress_offload.c
> @@ -849,7 +849,8 @@ static int snd_compress_dev_disconnect(struct snd_device *device)
> struct snd_compr *compr;
>
> compr = device->device_data;
> - snd_unregister_device(compr->direction, compr->card, compr->device);
> + snd_unregister_device(SNDRV_DEVICE_TYPE_COMPRESS, compr->card,
> + compr->device);
> return 0;
> }
>
> --
> 1.8.1.2
>
--
next prev parent reply other threads:[~2013-09-16 5:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-13 16:43 [PATCH] ALSA: compress: Make sure we trigger STOP before closing the stream Liam Girdwood
2013-09-13 16:43 ` [PATCH] ALSA: compress: Fix compress device unregister Liam Girdwood
2013-09-16 4:15 ` Vinod Koul [this message]
2013-09-16 4:22 ` Vinod Koul
2013-09-19 16:41 ` Takashi Iwai
2013-09-16 3:57 ` [PATCH] ALSA: compress: Make sure we trigger STOP before closing the stream Vinod Koul
2013-09-16 11:01 ` Liam Girdwood
2013-09-19 16:43 ` Takashi Iwai
2013-09-23 10:19 ` Liam Girdwood
2013-09-23 9:41 ` Vinod Koul
2013-09-26 7:58 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130916041501.GK17188@intel.com \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@linux.jf.intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).