From: Mark Brown <broonie@kernel.org>
To: Dylan Reid <dgreid@chromium.org>
Cc: Peter Hsiang <peter.hsiang@maxim-ic.com>,
alsa-devel@alsa-project.org, linaro-kernel@lists.linaro.org,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH 3/3] ASoC: max98095: Convert to direct regmap API usage
Date: Tue, 24 Sep 2013 11:13:30 +0100 [thread overview]
Message-ID: <20130924101329.GS21013@sirena.org.uk> (raw)
In-Reply-To: <CAEUnVG57r+9aAEZey5b8VytsOEpNhdqWR-Q7K9i8nfox4y03mQ@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 476 bytes --]
On Mon, Sep 23, 2013 at 07:56:53PM -0700, Dylan Reid wrote:
Please remember to delete unneeded context from e-mails, it makes it
much easier to find any new content you've added.
> > +
> > + .reg_defaults = max98095_reg_def,
> > + .num_reg_defaults = ARRAY_SIZE(max98095_reg_def),
> > + .max_register = M98095_0FF_REV_ID,
>
> is
> .cache_type = REGCACHE_RBTREE,
> needed here?
> I had to add it but only had an old 3.8 to test with.
Yes.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2013-09-24 10:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-23 18:10 [PATCH 1/3] ASoC: max98095: Remove custom hw_write() implementation Mark Brown
2013-09-23 18:10 ` [PATCH 2/3] ASoC: max90895: Convert to table based control init Mark Brown
2013-09-23 18:10 ` [PATCH 3/3] ASoC: max98095: Convert to direct regmap API usage Mark Brown
2013-09-24 2:56 ` Dylan Reid
2013-09-24 10:13 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130924101329.GS21013@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=dgreid@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=peter.hsiang@maxim-ic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox