From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ondrej Zary Subject: Re: [alsa-devel] [PATCH 2/2] [RESEND] snd-ac97-codec: Use complete =?iso-8859-1?q?ID=09when_the_codec_is_not?= known Date: Mon, 30 Sep 2013 20:42:03 +0200 Message-ID: <201309302042.04122.linux@rainbow-software.org> References: <201309272028.03764.linux@rainbow-software.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org To: alsa-devel@alsa-project.org Cc: Takashi Iwai , linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Monday 30 September 2013 11:08:50 Takashi Iwai wrote: > At Fri, 27 Sep 2013 20:28:03 +0200, > > Ondrej Zary wrote: > > Currently, if the codec ID is not known, the last byte of the ID is used > > as name. It's not helpful at all, use full codec ID instead. > > The full bytes are already shown at the beginning, no? > It's masked because the upper three bytes are shown in printable form, > and the last byte is usually a model number. Thanks, I see now. So this patch is not needed. > > Takashi > > > Signed-off-by: Ondrej Zary > > --- > > sound/pci/ac97/ac97_codec.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/sound/pci/ac97/ac97_codec.c b/sound/pci/ac97/ac97_codec.c > > index bf578ba2..30a40a8 100644 > > --- a/sound/pci/ac97/ac97_codec.c > > +++ b/sound/pci/ac97/ac97_codec.c > > @@ -1830,7 +1830,7 @@ void snd_ac97_get_name(struct snd_ac97 *ac97, > > unsigned int id, char *name, int m pid->patch(ac97); > > } > > } else > > - sprintf(name + strlen(name), " id %x", id & 0xff); > > + sprintf(name + strlen(name), " id %x", id); > > } > > > > /** > > -- > > Ondrej Zary > > _______________________________________________ > > Alsa-devel mailing list > > Alsa-devel@alsa-project.org > > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel -- Ondrej Zary