From: Steffen Trumtrar <s.trumtrar@pengutronix.de>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] ASoC: mc13783: add mixer controls
Date: Thu, 10 Oct 2013 09:34:11 +0200 [thread overview]
Message-ID: <20131010073411.GF14042@pengutronix.de> (raw)
In-Reply-To: <20131009151336.GO21581@sirena.org.uk>
Hi!
On Wed, Oct 09, 2013 at 04:13:36PM +0100, Mark Brown wrote:
> On Wed, Oct 09, 2013 at 05:01:44PM +0200, Steffen Trumtrar wrote:
>
> > +static const char * const mc13783_alsp[] = {"Off", "Codec", "Right"};
> > +
> > +static const char * const mc13783_ahs[] = {"Codec", "Mixer"};
>
> What are these - these look like they might be DAPM rather than regular
> controls?
>
Looks like you are right. Will fix.
> > + SOC_SINGLE("Headset Amp Right Switch", MC13783_AUDIO_RX0, 9, 1, 0),
> > + SOC_SINGLE("Headset Amp Left Switch", MC13783_AUDIO_RX0, 10, 1, 0),
>
> I would expect these to be stereo controls rather than two mono
> controls?
>
Okay.
> > + SOC_ENUM("Line out Amp Switch", mc13783_enum_arxout),
>
> Switches shouldn't be enums.
>
Hm, would "Line out Amp Source" be correct then? Or just "Line out Amp"?
I'm not really getting the documentation in that regard.
> > + SOC_SINGLE("Codec Capture Mix Switch", MC13783_AUDIO_RX0, 21, 1, 0),
>
> CODEC and Codec seem to be getting mixed in the file.
Okay. I will fix that.
Thanks,
Steffen
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2013-10-10 7:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-09 15:01 [PATCH] ASoC: mc13783: add mixer controls Steffen Trumtrar
2013-10-09 15:13 ` Mark Brown
2013-10-10 7:34 ` Steffen Trumtrar [this message]
2013-10-10 9:44 ` Mark Brown
2013-10-09 15:21 ` Lars-Peter Clausen
2013-10-10 7:36 ` Steffen Trumtrar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131010073411.GF14042@pengutronix.de \
--to=s.trumtrar@pengutronix.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).