alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Steffen Trumtrar <s.trumtrar@pengutronix.de>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] ASoC: mc13783: add mixer controls
Date: Thu, 10 Oct 2013 09:36:47 +0200	[thread overview]
Message-ID: <20131010073647.GG14042@pengutronix.de> (raw)
In-Reply-To: <52557484.1070808@metafoo.de>

On Wed, Oct 09, 2013 at 05:21:40PM +0200, Lars-Peter Clausen wrote:
> On 10/09/2013 05:01 PM, Steffen Trumtrar wrote:
> > [...]
> > +
> > +static const struct soc_enum mc13783_enum_asp =
> > +	SOC_ENUM_SINGLE(MC13783_AUDIO_RX0, 4, ARRAY_SIZE(mc13783_alsp),
> > +			mc13783_alsp);
> > +
> > +static const struct soc_enum mc13783_enum_alsp =
> > +	SOC_ENUM_SINGLE(MC13783_AUDIO_RX0, 7, ARRAY_SIZE(mc13783_alsp),
> > +			mc13783_alsp);
> > +
> > +static const struct soc_enum mc13783_enum_ahs =
> > +	SOC_ENUM_SINGLE(MC13783_AUDIO_RX0, 11, ARRAY_SIZE(mc13783_ahs),
> > +			mc13783_ahs);
> > +
> > +static const struct soc_enum mc13783_enum_arxout =
> > +	SOC_ENUM_SINGLE(MC13783_AUDIO_RX0, 17, ARRAY_SIZE(mc13783_ahs),
> > +			mc13783_ahs);
> > +
> > +static const struct soc_enum mc13783_enum_codec =
> > +	SOC_ENUM_SINGLE(MC13783_AUDIO_RX1, 4, ARRAY_SIZE(mc13783_alsp),
> > +			mc13783_alsp);
> 
> For bonus points use SOC_ENUM_SINGLE_DECL(...) ;)
> 

Yay, bonus points. I will change that.

Thanks,
Steffen

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

      reply	other threads:[~2013-10-10  7:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-09 15:01 [PATCH] ASoC: mc13783: add mixer controls Steffen Trumtrar
2013-10-09 15:13 ` Mark Brown
2013-10-10  7:34   ` Steffen Trumtrar
2013-10-10  9:44     ` Mark Brown
2013-10-09 15:21 ` Lars-Peter Clausen
2013-10-10  7:36   ` Steffen Trumtrar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131010073647.GG14042@pengutronix.de \
    --to=s.trumtrar@pengutronix.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lars@metafoo.de \
    --cc=lgirdwood@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).