From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Jean-Francois Moine <moinejf@free.fr>
Cc: "Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>,
alsa-devel@alsa-project.org,
"Jason Cooper" <jason@lakedaemon.net>,
"Mark Brown" <broonie@kernel.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-arm-kernel@lists.infradead.org,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH] ASoC: kirkwood: cleanup the external clock probe
Date: Mon, 21 Oct 2013 09:52:00 +0100 [thread overview]
Message-ID: <20131021085200.GW25034@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20131021102834.768c0887@armhf>
On Mon, Oct 21, 2013 at 10:28:34AM +0200, Jean-Francois Moine wrote:
> On Mon, 21 Oct 2013 09:06:57 +0100
> Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:
>
> > On Mon, Oct 21, 2013 at 09:46:13AM +0200, Jean-Francois Moine wrote:
> > > This patch checks the return value of the clk_prepare_enable of the
> > > external clock and removes the test about a same internal and external
> > > clock which would quite never occur and won't work in most cases
> > > it would occur.
> >
> > NAK. It can occur.
>
> In which case? And, what would be the right treatment?
priv->clk = devm_clk_get(&pdev->dev, NULL);
priv->extclk = devm_clk_get(&pdev->dev, "extclk");
Supplying the first clock to this driver without a separate "extclk"
via clkdev will return it as the second clock.
Again, NAK. Your change is against the principles of the clk API.
next prev parent reply other threads:[~2013-10-21 8:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-21 7:46 [PATCH] ASoC: kirkwood: cleanup the external clock probe Jean-Francois Moine
2013-10-21 8:06 ` Russell King - ARM Linux
2013-10-21 8:28 ` Jean-Francois Moine
2013-10-21 8:52 ` Russell King - ARM Linux [this message]
2013-10-21 10:09 ` Jean-Francois Moine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131021085200.GW25034@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=moinejf@free.fr \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).