From: Mark Brown <broonie@kernel.org>
To: Jean-Francois Moine <moinejf@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
alsa-devel@alsa-project.org, Jason Cooper <jason@lakedaemon.net>,
Liam Girdwood <lgirdwood@gmail.com>,
Russell King <rmk+kernel@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH v4] ASoC: kirkwood: add S/PDIF support
Date: Thu, 24 Oct 2013 12:08:33 +0100 [thread overview]
Message-ID: <20131024110833.GC18506@sirena.org.uk> (raw)
In-Reply-To: <20131021122422.4cde72c0@armhf>
[-- Attachment #1.1: Type: text/plain, Size: 1131 bytes --]
On Mon, Oct 21, 2013 at 12:24:22PM +0200, Jean-Francois Moine wrote:
> +static struct snd_soc_dai_driver kirkwood_i2s_dai[3] = {
> + DAI_DEF("i2s", 0,
> + SNDRV_PCM_RATE_44100 | SNDRV_PCM_RATE_48000 |
> + SNDRV_PCM_RATE_96000),
> + DAI_DEF("spdif", 1,
> + SNDRV_PCM_RATE_44100 | SNDRV_PCM_RATE_48000 |
> + SNDRV_PCM_RATE_96000),
> + DAI_DEF("i2s/spdif", 2,
> + SNDRV_PCM_RATE_44100 | SNDRV_PCM_RATE_48000 |
> + SNDRV_PCM_RATE_96000),
I didn't take this version because this third DAI reintroduces the
problem with having both S/PDIF and I2S in the single DAI. The problem
there is that you end up with one traditional DAI linked to two
different CODECs which the framework doesn't understand - it's
introducing a DAI which does what v1 does.
This is what DPCM addresses for this platform, it allows the single DMA
controller to be used in conjunction with the two external DAIs by
splitting the DMA from the DAI in the model the subsystem has.
Hopefully someone will have the time and enthusiasm to update to use
this and support systems that want to use I2S and S/PDIF simultaneously.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2013-10-24 11:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-21 10:24 [PATCH v4] ASoC: kirkwood: add S/PDIF support Jean-Francois Moine
2013-10-24 11:08 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131024110833.GC18506@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=jason@lakedaemon.net \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=moinejf@free.fr \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).