* [PATCH] ASoC: fsl_spdif: fix return value check in fsl_spdif_probe()
@ 2013-10-25 9:29 Wei Yongjun
2013-10-26 20:34 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2013-10-25 9:29 UTC (permalink / raw)
To: timur, lgirdwood, broonie, perex, tiwai, grant.likely,
rob.herring
Cc: yongjun_wei, linuxppc-dev, alsa-devel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
In case of error, the function platform_get_resource() returns NULL
pointer not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
sound/soc/fsl/fsl_spdif.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c
index 3920c3e..e5bfafe 100644
--- a/sound/soc/fsl/fsl_spdif.c
+++ b/sound/soc/fsl/fsl_spdif.c
@@ -1107,9 +1107,9 @@ static int fsl_spdif_probe(struct platform_device *pdev)
/* Get the addresses and IRQ */
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (IS_ERR(res)) {
+ if (!res) {
dev_err(&pdev->dev, "could not determine device resources\n");
- return PTR_ERR(res);
+ return -ENXIO;
}
regs = devm_ioremap_resource(&pdev->dev, res);
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ASoC: fsl_spdif: fix return value check in fsl_spdif_probe()
2013-10-25 9:29 [PATCH] ASoC: fsl_spdif: fix return value check in fsl_spdif_probe() Wei Yongjun
@ 2013-10-26 20:34 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2013-10-26 20:34 UTC (permalink / raw)
To: Wei Yongjun
Cc: alsa-devel, lgirdwood, tiwai, timur, rob.herring, yongjun_wei,
grant.likely, linuxppc-dev
[-- Attachment #1.1: Type: text/plain, Size: 318 bytes --]
On Fri, Oct 25, 2013 at 05:29:25PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> In case of error, the function platform_get_resource() returns NULL
> pointer not ERR_PTR(). The IS_ERR() test in the return value check
> should be replaced with NULL test.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-26 20:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-25 9:29 [PATCH] ASoC: fsl_spdif: fix return value check in fsl_spdif_probe() Wei Yongjun
2013-10-26 20:34 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).