From: Vinod Koul <vinod.koul@intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, broonie@kernel.org, lgirdwood@gmail.com
Subject: Re: [PATCHi v6] ALSA: compress: fix drain calls blocking other compress functions
Date: Thu, 7 Nov 2013 19:13:25 +0530 [thread overview]
Message-ID: <20131107134325.GA8834@intel.com> (raw)
In-Reply-To: <s5hhabova4i.wl%tiwai@suse.de>
On Thu, Nov 07, 2013 at 10:23:09AM +0100, Takashi Iwai wrote:
> At Thu, 7 Nov 2013 12:57:30 +0530,
> Vinod Koul wrote:
> >
> > The drain and drain_notify callback were blocked by low level driver untill the
> > draining was complete. Due to this being invoked with big fat mutex held, others
> > ops like reading timestamp, calling pause, drop were blocked.
> >
> > So to fix this we add a new snd_compr_drain_notify() API. This would be required
> > to be invoked by low level driver when drain or partial drain has been completed
> > by the DSP. Thus we make the drain and partial_drain callback as non blocking
> > and driver returns immediately after notifying DSP.
> > The waiting is done while relasing the lock so that other ops can go ahead.
> >
> > Signed-off-by: Vinod Koul <vinod.koul@intel.com>
> > CC: stable@vger.kernel.org
>
> Thanks, I apply this.
>
> Though... I found that I already applied your earlier version
> accidentally, and pushed it out a few weeks ago. If it were just a
> few commits, I'd rebase, but this was way too deep, so rebasing isn't
> good at all.
>
> In the end, I applied the patch correcting to the final version.
> The downside would be that you'll get two stable commit
> notifications. So, please beware of that.
>
> Sorry for confusions!
Np, I will cherry-pick both.
Now i will send you bunch of trvial chnages in compressed core which I wanted to
send once this one was done
--
~Vinod
prev parent reply other threads:[~2013-11-07 14:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 7:27 [PATCHi v6] ALSA: compress: fix drain calls blocking other compress functions Vinod Koul
2013-11-07 9:23 ` Takashi Iwai
2013-11-07 13:43 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131107134325.GA8834@intel.com \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).