From: Dan Carpenter <dan.carpenter@oracle.com>
To: kuninori.morimoto.gx@renesas.com
Cc: alsa-devel@alsa-project.org
Subject: Re: ASoC: add Renesas R-Car module feature
Date: Fri, 8 Nov 2013 13:02:06 +0300 [thread overview]
Message-ID: <20131108100206.GP27977@elgon.mountain> (raw)
Hello Kuninori Morimoto,
This is a semi-automatic email about new static checker warnings.
The patch cdaa3cdfb4a7: "ASoC: add Renesas R-Car module feature" from
Jul 21, 2013, leads to the following Smatch complaint:
sound/soc/sh/rcar/core.c:294 rsnd_dai_connect()
warn: variable dereferenced before check 'mod' (see line 291)
sound/soc/sh/rcar/core.c
290 {
291 struct rsnd_priv *priv = rsnd_mod_to_priv(mod);
^^^^^^^^^^^^^^^^^^^^^
Dereference.
292 struct device *dev = rsnd_priv_to_dev(priv);
293
294 if (!mod) {
^^^^
Check.
295 dev_err(dev, "NULL mod\n");
296 return -EIO;
regards,
dan carpenter
next reply other threads:[~2013-11-08 10:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-08 10:02 Dan Carpenter [this message]
2013-11-11 1:00 ` [PATCH] ASoC: rcar: fixup mod access before checking Kuninori Morimoto
2013-11-12 11:19 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131108100206.GP27977@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=alsa-devel@alsa-project.org \
--cc=kuninori.morimoto.gx@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).