From: Markus Pargmann <mpa@pengutronix.de>
To: Timur Tabi <timur@tabi.org>
Cc: alsa-devel mailing list <alsa-devel@alsa-project.org>,
Juergen Beisert <jbe@pengutronix.de>,
Liam Girdwood <lgirdwood@gmail.com>,
stable@vger.kernel.org, Mark Brown <broonie@kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [alsa-devel] [PATCH] ASoC: fsl-ssi: fix SDMA starvation
Date: Wed, 13 Nov 2013 13:16:30 +0100 [thread overview]
Message-ID: <20131113121630.GH30263@pengutronix.de> (raw)
In-Reply-To: <CAOZdJXUWv3_ZV6p9VQ+zYqwUDVQC6BMb-VhVoVtEh1yC23VuTg@mail.gmail.com>
Hi,
On Tue, Nov 12, 2013 at 02:17:34PM -0600, Timur Tabi wrote:
> On Tue, Nov 12, 2013 at 7:24 AM, Markus Pargmann <mpa@pengutronix.de> wrote:
> >
> > No, I don't have access on PowerPC hardware, so I didn't test it on
> > PowerPC.
>
> Can you change the code so that the interrupts are enabled only on
> i.MX? On PowerPC, the interrupts are used only for debugging.
Why is this necessary? The interrupts were enabled for all
architectures before.
However, this patch is wrong as Jürgen mentioned, the SIER_FLAGS are
written to the SIER register after we enable the DMA enable bits which
leads to missing DMA enable bits at the end.
I created a new patch to cleanup the whole interrupt flag setup. I will
post it later.
Regards,
Markus
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2013-11-13 12:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-12 11:17 [PATCH] ASoC: fsl-ssi: fix SDMA starvation Markus Pargmann
2013-11-12 12:55 ` Timur Tabi
2013-11-12 13:24 ` Markus Pargmann
2013-11-12 20:17 ` [alsa-devel] " Timur Tabi
2013-11-13 8:31 ` Jürgen Beisert
2013-11-13 13:11 ` Timur Tabi
2013-11-13 12:16 ` Markus Pargmann [this message]
2013-11-13 13:10 ` Timur Tabi
2013-11-13 13:38 ` Markus Pargmann
2013-11-13 14:15 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131113121630.GH30263@pengutronix.de \
--to=mpa@pengutronix.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jbe@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=stable@vger.kernel.org \
--cc=timur@tabi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).