From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Lucas Stach <dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
Cc: "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Mark Brown <broonie-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org
Subject: Re: [PATCH 3/3] ASOC: tegra: fix AC97 clock handling
Date: Mon, 18 Nov 2013 16:02:15 +0100 [thread overview]
Message-ID: <20131118150215.GH26046@ulmo.nvidia.com> (raw)
In-Reply-To: <1384370243-17178-3-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 677 bytes --]
On Wed, Nov 13, 2013 at 08:17:23PM +0100, Lucas Stach wrote:
[...]
> diff --git a/sound/soc/tegra/tegra20_ac97.c b/sound/soc/tegra/tegra20_ac97.c
[...]
> @@ -387,24 +386,18 @@ static int tegra20_ac97_platform_probe(struct platform_device *pdev)
> ac97->playback_dma_data.maxburst = 4;
> ac97->playback_dma_data.slave_id = of_dma[1];
>
> - ret = tegra_asoc_utils_init(&ac97->util_data, &pdev->dev);
> - if (ret)
> - goto err_clk_put;
> -
> - ret = tegra_asoc_utils_set_ac97_rate(&ac97->util_data);
> - if (ret)
> - goto err_asoc_utils_fini;
> + ret = clk_set_rate(ac97->clk_ac97, 24576000);
I think this needs error checking. Just in case.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-11-18 15:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1384370243-17178-1-git-send-email-dev@lynxeye.de>
[not found] ` <1384370243-17178-1-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
2013-11-13 19:17 ` [PATCH 2/3] ASOC: tegra: fix matching of AC97 components Lucas Stach
[not found] ` <1384370243-17178-2-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
2013-11-18 23:08 ` Stephen Warren
2013-11-13 19:17 ` [PATCH 3/3] ASOC: tegra: fix AC97 clock handling Lucas Stach
[not found] ` <1384370243-17178-3-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
2013-11-18 15:02 ` Thierry Reding [this message]
2013-11-18 23:15 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131118150215.GH26046@ulmo.nvidia.com \
--to=thierry.reding-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=broonie-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).