From: Lee Jones <lee.jones@linaro.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: alsa-devel@alsa-project.org, linus.walleij@linaro.org,
broonie@kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] ASoC: ux500: Dynamically fill DAI driver data on probe
Date: Tue, 3 Dec 2013 09:59:58 +0000 [thread overview]
Message-ID: <20131203095958.GH11828@lee--X1> (raw)
In-Reply-To: <529D9D14.9040109@metafoo.de>
> >>[...]
> >>>+void ux500_msp_populate_dai_drv(struct snd_soc_dai_driver *ux500_msp_dai_drv)
> >>>+{
> >>>+ ux500_msp_dai_drv->probe = ux500_msp_dai_probe;
> >>>+ ux500_msp_dai_drv->suspend = NULL;
> >>>+ ux500_msp_dai_drv->resume = NULL;
> >>>+ ux500_msp_dai_drv->playback.channels_min = UX500_MSP_MIN_CHANNELS;
> >>>+ ux500_msp_dai_drv->playback.channels_max = UX500_MSP_MAX_CHANNELS;
> >>>+ ux500_msp_dai_drv->playback.rates = UX500_I2S_RATES;
> >>>+ ux500_msp_dai_drv->playback.formats = UX500_I2S_FORMATS;
> >>>+ ux500_msp_dai_drv->capture.channels_min = UX500_MSP_MIN_CHANNELS;
> >>>+ ux500_msp_dai_drv->capture.channels_max = UX500_MSP_MAX_CHANNELS;
> >>>+ ux500_msp_dai_drv->capture.rates = UX500_I2S_RATES;
> >>>+ ux500_msp_dai_drv->capture.formats = UX500_I2S_FORMATS;
> >>>+ ux500_msp_dai_drv->ops = ux500_msp_dai_ops;
> >>> };
> >>
> >>You can just use the same static driver for all devices. No need to
> >>dynamically allocate it.
> >
> >How do you mean? Just create a 'static struct' instead?
>
> Yes.
>
> static struct snd_soc_dai_driver ux500_msp_dai_driver = {
> ...
> };
Yes, that's no issue. I was more focused on the reduction of code
than anything else, but that is a better idea.
I'll resubmit.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2013-12-03 10:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 18:00 [PATCH 1/3] ASoC: ux500_pcm: Stop pretending that we support varying address widths Lee Jones
2013-12-02 18:00 ` [PATCH 2/3] ASoC: ux500_pcm: Differentiate between pdata and DT initialisation Lee Jones
2013-12-02 18:13 ` [alsa-devel] " Lars-Peter Clausen
2013-12-03 8:36 ` Lee Jones
2013-12-03 8:56 ` Lars-Peter Clausen
2013-12-03 10:03 ` Lee Jones
2013-12-02 18:00 ` [PATCH 3/3] ASoC: ux500: Dynamically fill DAI driver data on probe Lee Jones
2013-12-02 18:10 ` [alsa-devel] " Lars-Peter Clausen
2013-12-03 8:40 ` Lee Jones
2013-12-03 8:57 ` Lars-Peter Clausen
2013-12-03 9:59 ` Lee Jones [this message]
2013-12-02 18:34 ` [alsa-devel] [PATCH 1/3] ASoC: ux500_pcm: Stop pretending that we support varying address widths Lars-Peter Clausen
2013-12-03 8:31 ` Lee Jones
2013-12-02 19:09 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131203095958.GH11828@lee--X1 \
--to=lee.jones@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).