alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Nicolin Chen <b42378@freescale.com>
To: Mark Brown <broonie@kernel.org>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org, lgirdwood@gmail.com
Subject: Re: [PATCH] ASoC: fsl: imx-wm8962: Do FLL configuration in hw_params() and hw_kree()
Date: Thu, 5 Dec 2013 19:07:28 +0800	[thread overview]
Message-ID: <20131205110727.GA14744@MrMyself> (raw)
In-Reply-To: <20131205111508.GM29268@sirena.org.uk>

On Thu, Dec 05, 2013 at 11:15:08AM +0000, Mark Brown wrote:
> On Thu, Dec 05, 2013 at 10:56:31AM +0800, Nicolin Chen wrote:
> 
> > As far as I can understand, the point that all the outputs needs the device
> > to be clocked is undeniably true, but the external MCLK should be sufficient
> > to source the SYSCLK of WM8962. Does the bypass mode also need to set FLL
> > to get an accurate frequency?
> 
> The device is going to need a clock that's in spec to make sure that the
> device performs in spec, if the device is clocked from a 32kHz clock
> (which is quite a common configuration and one that's supported by the
> machine driver since it gets the clock from DT) that's definitely not
> going to be the case and I'd not expect it to work at all sensibly.

Thank you for the explain. I understand now.

Then I think it would be plausible if I could refine this patch to
allow both set_bias_level() and hw_params/free() to control the FLL
while making them not break each other but coexist, right?

Thank you,
Nicolin Chen

  reply	other threads:[~2013-12-05 11:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-04 16:54 [PATCH] ASoC: fsl: imx-wm8962: Do FLL configuration in hw_params() and hw_free() Nicolin Chen
2013-12-04 19:02 ` Mark Brown
2013-12-05  2:56   ` Nicolin Chen
2013-12-05 11:15     ` [PATCH] ASoC: fsl: imx-wm8962: Do FLL configuration in hw_params() and hw_kree() Mark Brown
2013-12-05 11:07       ` Nicolin Chen [this message]
2013-12-05 12:21         ` Mark Brown
2013-12-05 14:17           ` Nicolin Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131205110727.GA14744@MrMyself \
    --to=b42378@freescale.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).