From: Mark Brown <broonie@kernel.org>
To: Padma Venkat <padma.kvr@gmail.com>
Cc: Padmavathi Venna <padma.v@samsung.com>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
alsa-devel@alsa-project.org, Kukjin Kim <kgene.kim@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
lars@metafoo.de
Subject: Re: [PATCH] ASoC: samsung: Initialize the dma_data for secondary dai
Date: Thu, 5 Dec 2013 11:50:15 +0000 [thread overview]
Message-ID: <20131205115015.GP29268@sirena.org.uk> (raw)
In-Reply-To: <CAAgF-BdqRzB5MxTf_9nZkgSOY=F6dGAs0yhTkNHqrUQLonFAsw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1020 bytes --]
On Thu, Dec 05, 2013 at 04:33:19PM +0530, Padma Venkat wrote:
> On Thu, Nov 28, 2013 at 5:08 PM, Mark Brown <broonie@kernel.org> wrote:
> > Why don't we need this fix for mainline? The dmaengine change is just
> > moving the initialisation through a layer of indirection but there was
> > initialisation anyway. I'm concerned that there's a bug that ought to
> > be fixed for v3.13 as well here.
> Yes. We need this for mainline. Not dependent on your dmaengine changes.
Ah, just saw this one - I'll cook up a version of it, due to the
refactoring the change doesn't apply directly to v3.13.
> >> return snd_dmaengine_pcm_register(dev, &samsung_dmaengine_pcm_config,
> >> - SND_DMAENGINE_PCM_FLAG_COMPAT);
> >> + SND_DMAENGINE_PCM_FLAG_COMPAT |
> >> + SND_DMAENGINE_PCM_FLAG_CUSTOM_CHANNEL_NAME);
> > This is already done.
> Should I send another patch by removing this flag from this patch?
No need.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-12-05 11:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 10:02 [PATCH] ASoC: samsung: Initialize the dma_data for secondary dai Padmavathi Venna
2013-11-28 11:38 ` Mark Brown
2013-12-05 11:03 ` Padma Venkat
2013-12-05 11:50 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131205115015.GP29268@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=kgene.kim@samsung.com \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=padma.kvr@gmail.com \
--cc=padma.v@samsung.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).