From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Mark Brown <broonie@kernel.org>
Cc: vinod.koul@linux.intel.com, patches@opensource.wolfsonmicro.com,
alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/2 v2] crec: Add primitive exception handling
Date: Thu, 5 Dec 2013 14:25:28 +0000 [thread overview]
Message-ID: <20131205142528.GG23979@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20131203201828.GC29268@sirena.org.uk>
On Tue, Dec 03, 2013 at 08:18:28PM +0000, Mark Brown wrote:
> On Tue, Dec 03, 2013 at 06:22:56PM +0000, Mark Brown wrote:
>
> > You can't safely do most of this such as calling fclose() from within a
> > signal handler, the set of functions that are guaranteed safe is quite
> > limited - see signal(7).
>
> I should also have mentioned that it looks like you're probably looking
> for setvbuf() with _IONBF.
All good points, it is probably worth just merging the first
patch in the series for now and I can have a more detailed look
at the second patch.
Tricky thing is making 100% sure we don't enter a poll
after we have received the signal, especially if we are just
using the standard pattern of communicating the signal using a
sig_atomic_t.
Thanks,
Charles
next prev parent reply other threads:[~2013-12-05 14:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 16:27 [PATCH 1/2 v2] crec: Initial version of a compressed capture utility Charles Keepax
2013-12-03 16:27 ` [PATCH 2/2 v2] crec: Add primitive exception handling Charles Keepax
2013-12-03 18:22 ` Mark Brown
2013-12-03 20:18 ` Mark Brown
2013-12-05 14:25 ` Charles Keepax [this message]
2013-12-05 14:57 ` Mark Brown
2013-12-08 14:47 ` Charles Keepax
2013-12-11 11:15 ` Dimitris Papastamos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131205142528.GG23979@opensource.wolfsonmicro.com \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=vinod.koul@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).