From: Mark Brown <broonie@kernel.org>
To: Padma Venkat <padma.kvr@gmail.com>
Cc: Padmavathi Venna <padma.v@samsung.com>,
alsa-devel@alsa-project.org,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
linaro-kernel@lists.linaro.org
Subject: Re: [alsa-devel] [PATCH 1/2] ASoC: samsung: Provide helper for DMA init
Date: Fri, 6 Dec 2013 11:27:08 +0000 [thread overview]
Message-ID: <20131206112708.GD29268@sirena.org.uk> (raw)
In-Reply-To: <CAAgF-BdD_DONQYPOenMwBmc6N+EOJQ3TwJz1hpG2qZVfzhR63Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 792 bytes --]
On Fri, Dec 06, 2013 at 10:44:33AM +0530, Padma Venkat wrote:
> This is done in your earlier patch " ASoC: samsung: Ensure DMA data is
> initialised for secondary DAI ". Was it done on purpose or by mistake
> in this patch?
It's intentional - notice that the function has changed, this is why I
kept asking you about mainline. Mainline doesn't have the wrapper
function that abstracts the difference between s3c-dma and dmaengine,
this is why I'm saying these two will need to be rebased on top of the
mainline fix.
> I think you also told to include a patch for reinitialization of the
> dma_data in i2s_hw_params. If you are in the process of debugging some
> bug as you mentioned earlier you can ignore this comment. Otherwise it
> is just a reminder.
Hrm, forgot to commit that bit.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-12-06 11:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 14:25 [PATCH 1/2] ASoC: samsung: Provide helper for DMA init Mark Brown
2013-12-05 14:25 ` [PATCH 2/2] ASoC: samsung: Use ASoC dmaengine code where possible Mark Brown
2013-12-06 5:14 ` [alsa-devel] " Padma Venkat
2013-12-09 17:30 ` Mark Brown
2013-12-10 16:39 ` Padma Venkat
2013-12-10 17:01 ` Mark Brown
2013-12-06 5:14 ` [alsa-devel] [PATCH 1/2] ASoC: samsung: Provide helper for DMA init Padma Venkat
2013-12-06 11:27 ` Mark Brown [this message]
2013-12-09 12:00 ` Padma Venkat
2013-12-09 17:15 ` Padma Venkat
2013-12-09 17:17 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2013-11-12 13:48 Mark Brown
2013-11-26 5:24 ` [alsa-devel] " Padma Venkat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131206112708.GD29268@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=padma.kvr@gmail.com \
--cc=padma.v@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).