From: Nicolin Chen <b42378@freescale.com>
To: Mark Brown <broonie@kernel.org>
Cc: lgirdwood@gmail.com, alsa-devel@alsa-project.org, tiwai@suse.de,
perex@perex.cz, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] ASoC: fsl: imx-wm8962: Grant hw_params/free() permission to control FLL
Date: Fri, 6 Dec 2013 22:31:39 +0800 [thread overview]
Message-ID: <20131206143138.GA29975@MrMyself> (raw)
In-Reply-To: <20131206143433.GH29268@sirena.org.uk>
On Fri, Dec 06, 2013 at 02:34:33PM +0000, Mark Brown wrote:
> On Fri, Dec 06, 2013 at 05:47:43PM +0800, Nicolin Chen wrote:
>
> > +static int imx_wm8962_enable_fll(struct snd_soc_dai *codec_dai, u32 sample_rate,
> > + snd_pcm_format_t sample_format)
> > +{
> > + struct imx_priv *priv = &card_priv;
> > + struct device *dev = &priv->pdev->dev;
> > + struct imx_wm8962_data *data = platform_get_drvdata(priv->pdev);
> > + u32 freq, ret;
> > +
> > + if (data->fll_lock)
> > + return 0;
>
> Don't we need an actual lock to protect this?
Thank you for the advice, I will revise it.
Best regards,
Nicolin Chen
next prev parent reply other threads:[~2013-12-06 14:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 9:47 [PATCH 0/3] Enhance imx-wm8962 machine driver Nicolin Chen
2013-12-06 9:47 ` [PATCH 1/3] ASoC: fsl: imx-wm8962: Don't update bias_level in " Nicolin Chen
2013-12-06 9:47 ` [PATCH 2/3] ASoC: fsl: imx-wm8962: Grant hw_params/free() permission to control FLL Nicolin Chen
2013-12-06 14:34 ` Mark Brown
2013-12-06 14:31 ` Nicolin Chen [this message]
[not found] ` <cover.1386322845.git.b42378-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2013-12-06 9:48 ` [PATCH 3/3] ASoC: fsl: imx-wm8962: Add headphone and microphone jack plugin/out detection Nicolin Chen
2013-12-06 14:42 ` Mark Brown
2013-12-06 14:38 ` Nicolin Chen
2013-12-06 15:03 ` Mark Brown
2013-12-06 14:52 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131206143138.GA29975@MrMyself \
--to=b42378@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).