From: Mark Brown <broonie@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>,
alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] ASoC: tlv320aic3x: Correct S24_3LE support
Date: Fri, 13 Dec 2013 13:49:06 +0000 [thread overview]
Message-ID: <20131213134906.GD11044@sirena.org.uk> (raw)
In-Reply-To: <52AB0EC8.5020802@metafoo.de>
[-- Attachment #1.1: Type: text/plain, Size: 590 bytes --]
On Fri, Dec 13, 2013 at 02:42:32PM +0100, Lars-Peter Clausen wrote:
> Normally you'd expect the I2S core to only put the 24 bits of data onto the
> bus for both S24_3LE and S24_LE (it might add necessary trailing padding if
> the bit clocks per frame is > 24). A CODEC driver should really not have to
> care about the in memory layout of the data since all it will see is a
> serialized bit stream. I think ideally we wouldn't check for params_format()
> but rather for snd_pcm_format_width(params_format()).
Yes, that would be a much better approach. In fact, let me go attack
that...
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2013-12-13 13:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 12:58 [PATCH] ASoC: tlv320aic3x: Correct S24_3LE support Peter Ujfalusi
2013-12-13 13:04 ` Mark Brown
2013-12-13 13:29 ` Peter Ujfalusi
2013-12-13 13:34 ` Mark Brown
2013-12-13 13:41 ` Takashi Iwai
2013-12-13 13:50 ` Mark Brown
2013-12-13 13:57 ` Peter Ujfalusi
2013-12-13 14:18 ` Mark Brown
2013-12-13 14:31 ` Peter Ujfalusi
2013-12-13 18:29 ` Mark Brown
2013-12-13 13:42 ` Lars-Peter Clausen
2013-12-13 13:49 ` Mark Brown [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-06-06 13:05 Peter Ujfalusi
2014-06-09 20:24 ` Mark Brown
2014-06-23 13:01 ` Peter Ujfalusi
2014-06-23 15:18 ` Mark Brown
2014-06-24 6:23 ` Peter Ujfalusi
2014-06-24 9:18 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131213134906.GD11044@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).