From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [PATCH] ALSA: compress: Fix 64bit ABI incompatibility Date: Sun, 15 Dec 2013 19:27:40 +0530 Message-ID: <20131215135740.GT29580@intel.com> References: <1386685997-4838-1-git-send-email-tiwai@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by alsa0.perex.cz (Postfix) with ESMTP id 37BAD261AED for ; Sun, 15 Dec 2013 15:56:25 +0100 (CET) Content-Disposition: inline In-Reply-To: <1386685997-4838-1-git-send-email-tiwai@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Takashi Iwai Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Tue, Dec 10, 2013 at 03:33:17PM +0100, Takashi Iwai wrote: > snd_pcm_uframes_t is defined as unsigned long so it would take > different sizes depending on 32 or 64bit architectures. As we don't > want this ABI incompatibility, and there is no real 64bit user yet, > let's make it the fixed size with __u32. > > Also bump the protocol version number to 0.1.2. Was this applied? > > Acked-by: Vinod Koul > Cc: > Signed-off-by: Takashi Iwai > --- > include/uapi/sound/compress_offload.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/uapi/sound/compress_offload.h b/include/uapi/sound/compress_offload.h > index d630163b9a2e..5759810e1c1b 100644 > --- a/include/uapi/sound/compress_offload.h > +++ b/include/uapi/sound/compress_offload.h > @@ -30,7 +30,7 @@ > #include > > > -#define SNDRV_COMPRESS_VERSION SNDRV_PROTOCOL_VERSION(0, 1, 1) > +#define SNDRV_COMPRESS_VERSION SNDRV_PROTOCOL_VERSION(0, 1, 2) > /** > * struct snd_compressed_buffer: compressed buffer > * @fragment_size: size of buffer fragment in bytes > @@ -67,8 +67,8 @@ struct snd_compr_params { > struct snd_compr_tstamp { > __u32 byte_offset; > __u32 copied_total; > - snd_pcm_uframes_t pcm_frames; > - snd_pcm_uframes_t pcm_io_frames; > + __u32 pcm_frames; > + __u32 pcm_io_frames; > __u32 sampling_rate; > }; > > -- > 1.8.5 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel --