From: Jean-Francois Moine <moinejf@free.fr>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH 08/19] ASoC: kirkwood: Don't set unused struct snd_pcm_hardware fields
Date: Fri, 20 Dec 2013 19:05:06 +0100 [thread overview]
Message-ID: <20131220190506.2adb7a52@armhf> (raw)
In-Reply-To: <1387545625-19240-8-git-send-email-lars@metafoo.de>
On Fri, 20 Dec 2013 14:20:14 +0100
Lars-Peter Clausen <lars@metafoo.de> wrote:
> The ASoC core assumes that the PCM component of the ASoC card transparently
> moves data around and does not impose any restrictions on the memory layout or
> the transfer speed. It ignores all fields from the snd_pcm_hardware struct for
> the PCM driver that are related to this. Setting these fields in the PCM driver
> might suggest otherwise though, so rather not set them.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Jean-Francois Moine <moinejf@free.fr>
> ---
> sound/soc/kirkwood/kirkwood-dma.c | 16 ----------------
> 1 file changed, 16 deletions(-)
>
> diff --git a/sound/soc/kirkwood/kirkwood-dma.c b/sound/soc/kirkwood/kirkwood-dma.c
> index 4af1936..aac22fc 100644
> --- a/sound/soc/kirkwood/kirkwood-dma.c
> +++ b/sound/soc/kirkwood/kirkwood-dma.c
[snip]
> @@ -43,12 +33,6 @@ static struct snd_pcm_hardware kirkwood_dma_snd_hw = {
> SNDRV_PCM_INFO_MMAP_VALID |
> SNDRV_PCM_INFO_BLOCK_TRANSFER |
> SNDRV_PCM_INFO_PAUSE),
> - .formats = KIRKWOOD_FORMATS,
> - .rates = KIRKWOOD_RATES,
> - .rate_min = 8000,
> - .rate_max = 384000,
> - .channels_min = 1,
> - .channels_max = 8,
> .buffer_bytes_max = KIRKWOOD_SND_MAX_BUFFER_BYTES,
> .period_bytes_min = KIRKWOOD_SND_MIN_PERIOD_BYTES,
> .period_bytes_max = KIRKWOOD_SND_MAX_PERIOD_BYTES,
Lars,
You removed too many things. The 'formats' field is mandatory.
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2013-12-20 18:05 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 13:20 [PATCH 01/19] ASoC: atmel: Don't set unused struct snd_pcm_hardware fields Lars-Peter Clausen
2013-12-20 13:20 ` [PATCH 02/19] ASoC: au1x: " Lars-Peter Clausen
2013-12-20 15:24 ` Manuel Lauss
2013-12-21 14:24 ` Mark Brown
2013-12-20 13:20 ` [PATCH 03/19] ASoC: blackfin: " Lars-Peter Clausen
2013-12-24 11:54 ` Mark Brown
2013-12-20 13:20 ` [PATCH 04/19] ASoC: davinci: " Lars-Peter Clausen
2013-12-23 7:04 ` Peter Ujfalusi
2013-12-24 12:01 ` Mark Brown
2013-12-20 13:20 ` [PATCH 05/19] ASoC: ep93xx: " Lars-Peter Clausen
2013-12-30 13:59 ` Mark Brown
2013-12-20 13:20 ` [PATCH 06/19] ASoC: fsl: " Lars-Peter Clausen
2013-12-20 14:25 ` Timur Tabi
2013-12-20 14:04 ` Lars-Peter Clausen
2013-12-20 18:27 ` Mark Brown
2013-12-20 18:16 ` Lars-Peter Clausen
2013-12-20 13:20 ` [PATCH 07/19] ASoC: intel: " Lars-Peter Clausen
2013-12-20 13:20 ` [PATCH 08/19] ASoC: kirkwood: " Lars-Peter Clausen
2013-12-20 18:05 ` Jean-Francois Moine [this message]
2013-12-20 17:18 ` Lars-Peter Clausen
2013-12-20 19:13 ` Jean-Francois Moine
2013-12-20 18:29 ` Lars-Peter Clausen
2013-12-20 13:20 ` [PATCH 09/19] ASoC: mxs: " Lars-Peter Clausen
2013-12-20 13:20 ` [PATCH 10/19] ASoC: nuc900: " Lars-Peter Clausen
2013-12-20 13:20 ` [PATCH 11/19] ASoC: omap: " Lars-Peter Clausen
2013-12-22 17:19 ` Jarkko Nikula
2013-12-23 7:04 ` Peter Ujfalusi
2013-12-24 12:04 ` Mark Brown
2013-12-20 13:20 ` [PATCH 12/19] ASoC: mmp: " Lars-Peter Clausen
2013-12-30 13:59 ` Mark Brown
2013-12-20 13:20 ` [PATCH 13/19] ASoC: s6000: " Lars-Peter Clausen
2013-12-22 22:21 ` Daniel Glöckner
2013-12-24 12:02 ` Mark Brown
2013-12-20 13:20 ` [PATCH 14/19] ASoC: samsung: " Lars-Peter Clausen
2013-12-30 13:57 ` Mark Brown
2013-12-20 13:20 ` [PATCH 15/19] ASoC: sh: " Lars-Peter Clausen
2013-12-20 13:20 ` [PATCH 16/19] ASoC: tegra: " Lars-Peter Clausen
2013-12-20 17:43 ` Stephen Warren
2013-12-21 14:27 ` Mark Brown
2013-12-20 13:20 ` [PATCH 17/19] ASoC: txx9: " Lars-Peter Clausen
2013-12-30 13:58 ` Mark Brown
2013-12-20 13:20 ` [PATCH 18/19] ASoC: ux500: " Lars-Peter Clausen
2013-12-20 13:20 ` [PATCH 19/19] ASoC: soc-utils: " Lars-Peter Clausen
2013-12-30 13:56 ` Mark Brown
2014-01-04 18:15 ` [PATCH 01/19] ASoC: atmel: " Lars-Peter Clausen
2014-01-06 3:01 ` Bo Shen
2014-01-06 16:45 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2013-12-30 19:42 [PATCH 08/19] ASoC: kirkwood: " Jean-Francois Moine
2014-01-01 20:10 ` Lars-Peter Clausen
2014-01-02 11:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131220190506.2adb7a52@armhf \
--to=moinejf@free.fr \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).