Re: [PATCH 08/19] ASoC: kirkwood: Don't set unused struct snd_pcm_hardware fields

[Jean-Francois Moine <moinejf@free.fr>]

> On 12/20/2013 08:13 PM, Jean-Francois Moine wrote:
> > On Fri, 20 Dec 2013 18:18:49 +0100
> > Lars-Peter Clausen <lars@metafoo.de> wrote:
> >   
> >> On 12/20/2013 07:05 PM, Jean-Francois Moine wrote:  
> >>>> diff --git a/sound/soc/kirkwood/kirkwood-dma.c b/sound/soc/kirkwood/kirkwood-dma.c
> >>>> index 4af1936..aac22fc 100644
> >>>> --- a/sound/soc/kirkwood/kirkwood-dma.c
> >>>> +++ b/sound/soc/kirkwood/kirkwood-dma.c  
> >>> 	[snip]  
> >>>> @@ -43,12 +33,6 @@ static struct snd_pcm_hardware kirkwood_dma_snd_hw = {
> >>>>  		 SNDRV_PCM_INFO_MMAP_VALID |
> >>>>  		 SNDRV_PCM_INFO_BLOCK_TRANSFER |
> >>>>  		 SNDRV_PCM_INFO_PAUSE),
> >>>> -	.formats		= KIRKWOOD_FORMATS,
> >>>> -	.rates			= KIRKWOOD_RATES,
> >>>> -	.rate_min		= 8000,
> >>>> -	.rate_max		= 384000,
> >>>> -	.channels_min		= 1,
> >>>> -	.channels_max		= 8,
> >>>>  	.buffer_bytes_max	= KIRKWOOD_SND_MAX_BUFFER_BYTES,
> >>>>  	.period_bytes_min	= KIRKWOOD_SND_MIN_PERIOD_BYTES,
> >>>>  	.period_bytes_max	= KIRKWOOD_SND_MAX_PERIOD_BYTES,  
> >>>
> >>> Lars,
> >>>
> >>> You removed too many things. The 'formats' field is mandatory.  
> >>
> >> No it is not. While snd_soc_set_runtime_hwparams() uses it it is later
> >> overwritten again in soc_pcm_init_runtime_hw().  
> > 
> > I have a DPCM system and soc_pcm_init_runtime_hw() is not called
> > (either 'dynamic' or 'no_pcm' is set in the DAI links).
> 
> Ok, I see dpcm_set_fe_runtime() does things slightly different.

Well, I advanced a bit with DPCM, and I have a problem with this field.

In the driver, the front-end DAI is the audio controller and the
back-ends DAIs are the HDMI and SPDIF outputs. These back-end DAIs
have different rates and formats, as have the audio controller outputs
(I2S and SPDIF). So, I used intermediate DAIs which represent the audio
controller outputs, and they are described in the DAI links:

link 0 (FE): audio controller <-> dummy DAI
link 1 (BE): i2s audio controller output <-> HDMI output
link 2 (BE): spdif audio controller output <-> HDMI output
link 3 (BE): spdif audio controller output <-> SPDIF output

Without any patch in the core, the rates and formats are always the
rates and formats of the audio controller (FE). This is due to the
'goto dynamic' in soc_pcm_open(): as the back-ends are linked to real
DAIs, the rate and format constraints must be checked. So, as a
temporary patch, I replaced:

	if (rtd->dai_link->dynamic || rtd->dai_link->no_pcm)
		goto dynamic;
by:
	if (rtd->dai_link->dynamic)
		goto dynamic;

(indeed, this will not work if the back-end is linked to the dummy DAI)

and, I get the correct rates and formats in the runtime hardware
parameters. But these values are lost:

- on DMA open (FE pcm open), when the driver calls
  snd_soc_set_runtime_hwparams() (loss of the formats), and

- on dpcm_set_fe_runtime() call (loss of the rates).

The first problem can be fixed in the audio controller by a hack,
saving /restoring the formats on calling snd_soc_set_runtime_hwparams(),
and the second problem is easily fixed moving dpcm_set_fe_runtime() at
the beginning of dpcm_fe_dai_startup(). Are these good solutions?

-- 
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel