Re: [PATCH 2/2] ASoC: compress: Add suport for DPCM into compressed audio

[Vinod Koul <vinod.koul@intel.com>]

On Thu, Jan 16, 2014 at 05:08:01PM +0000, Liam Girdwood wrote:
> On Thu, 2014-01-16 at 16:59 +0100, Takashi Iwai wrote:
> > At Wed, 15 Jan 2014 16:51:57 +0000,
> > Liam Girdwood wrote:
> > > 
> 
> > 
> > > +	mutex_lock_nested(&fe->card->mutex, SND_SOC_CARD_CLASS_RUNTIME);
> > > +
> > > +	if (platform->driver->compr_ops && platform->driver->compr_ops->set_params) {
> > > +		ret = platform->driver->compr_ops->set_params(cstream, params);
> > > +		if (ret < 0)
> > > +			goto out;
> > > +	}
> > > +
> > > +	if (fe->dai_link->compr_ops && fe->dai_link->compr_ops->set_params) {
> > > +		ret = fe->dai_link->compr_ops->set_params(cstream);
> > > +		if (ret < 0)
> > > +			goto out;
> > > +	}
> > > +
> > > +	memcpy(&fe->dpcm[fe_substream->stream].hw_params, params,
> > > +			sizeof(struct snd_pcm_hw_params));
> > 
> > Does this really work?  params is snd_compr_params and hw_parmas is
> > snd_pcm_hw_params, isn't it?
> > 
> 
> Hmmm, no one reported a failure here to me. It is complete nonsense
> though so I dont know why the testers didn't run into this. I'll fix it
> for V2.
I think that due to the fixup fn noone noticed this. The issue will be seen only
by folks who dont have the fixup function.

--
~Vinod