From: Mark Brown <broonie@kernel.org>
To: Richard Weinberger <richard@nod.at>
Cc: Ben Dooks <ben-linux@fluff.org>,
Kukjin Kim <kgene.kim@samsung.com>,
Sangbeom Kim <sbkim73@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.de>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 14/28] Remove MACH_SMDKC210
Date: Mon, 10 Feb 2014 11:41:54 +0000 [thread overview]
Message-ID: <20140210114154.GQ1757@sirena.org.uk> (raw)
In-Reply-To: <1391971686-9517-15-git-send-email-richard@nod.at>
[-- Attachment #1: Type: text/plain, Size: 963 bytes --]
On Sun, Feb 09, 2014 at 07:47:52PM +0100, Richard Weinberger wrote:
> The symbol is an orphan, get rid of it.
Please fix whatever script you're using to generate your mails, it's
generating corrupt headers. Please also use subject lines consistent
with the rest of the subsystem - between the two I very nearly just
deleted this unread, it's only Paul's mail that made me look.
> config SND_SOC_SAMSUNG_SMDK_WM9713
> tristate "SoC AC97 Audio support for SMDK with WM9713"
> - depends on SND_SOC_SAMSUNG && (MACH_SMDK6410 || MACH_SMDKC100 || MACH_SMDKV210 || MACH_SMDKC110 || MACH_SMDKV310 || MACH_SMDKC210)
> + depends on SND_SOC_SAMSUNG && (MACH_SMDK6410 || MACH_SMDKC100 || MACH_SMDKV210 || MACH_SMDKC110 || MACH_SMDKV310)
Like I said to Paul this isn't fixing the actual issue - think about why
the symbol was there in the first place and why it was removed. There
is a problem here but this would make it less likely that it would be
properly fixed.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-02-10 11:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1391971686-9517-1-git-send-email-richard@nod.at>
2014-02-09 18:47 ` [PATCH 14/28] Remove MACH_SMDKC210 Richard Weinberger
2014-02-10 11:41 ` Mark Brown [this message]
2014-02-10 13:31 ` Paul Bolle
2014-02-10 14:12 ` Mark Brown
2014-02-10 15:30 ` Paul Bolle
2014-02-10 16:36 ` Mark Brown
2014-02-10 22:09 ` Paul Bolle
2014-02-12 16:04 ` Mark Brown
2014-02-28 21:43 ` Paul Bolle
2014-03-01 3:53 ` Mark Brown
2014-02-09 18:48 ` [PATCH 25/28] Remove MACH_SMDKV310 Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140210114154.GQ1757@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=ben-linux@fluff.org \
--cc=kgene.kim@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=perex@perex.cz \
--cc=richard@nod.at \
--cc=sbkim73@samsung.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox