From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Subject: Re: Regression caused by "ASoC: core: Rework SOC_DOUBLE_R_SX_TLV add SOC_SINGLE_SX_TLV" Date: Mon, 10 Feb 2014 15:22:44 +0100 Message-ID: <20140210152244.19f9d647@skate> References: <20140130144807.5b102b28@skate> <20140130160554.694a8a84@skate> <20140130175658.11469081@skate> <20140130181607.6a694b8f@skate> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.free-electrons.com (top.free-electrons.com [176.31.233.9]) by alsa0.perex.cz (Postfix) with ESMTP id B70D22619D6 for ; Mon, 10 Feb 2014 15:23:06 +0100 (CET) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Brian Austin Cc: Lior Amsalem , alsa-devel@alsa-project.org, Liam Girdwood , Mark Brown , Ezequiel Garcia , Gregory =?UTF-8?B?Q2zDqW1lbnQ=?= List-Id: alsa-devel@alsa-project.org Dear Brian Austin, On Thu, 30 Jan 2014 11:23:57 -0600, Brian Austin wrote: > >> SOC_DOUBLE_R_SX_TLV("Analog Playback Volume", > >> CS42L51_AOUTA_VOL, CS42L51_AOUTB_VOL, > >> - 0, 0x34, 0xE4, aout_tlv), > >> + 8, 0xffffff19, 0x18, aout_tlv), > >> SOC_DOUBLE_R_SX_TLV("ADC Mixer Volume", > >> > >> shifting 8 on an 8bit register? > > > > These values are just the ones that were here before your commit > > 1d99f2436d0d1c7741d6dfd9d27b5376cdbbca40. I didn't invent anything, > > just reverted partially your commit. > > > Oh yes, of course. I was just making the comment that it looks very > strange to have that shift value. I'm glad it works for your system and > you can go forward with your development. > > Once I get it figured out, I'll CC you on the submission for your review > and test. Any news about this volume control problem on cs42l51 ? Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com