From: Jason Cooper <jason@lakedaemon.net>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Lior Amsalem <alior@marvell.com>, Andrew Lunn <andrew@lunn.ch>,
alsa-devel@alsa-project.org, Tawfik Bayouk <tawfik@marvell.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
Gregory Clement <gregory.clement@free-electrons.com>,
linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH v2 0/7] Audio support for Armada 370 DB
Date: Sun, 16 Feb 2014 21:46:38 -0500 [thread overview]
Message-ID: <20140217024638.GH7862@titan.lakedaemon.net> (raw)
In-Reply-To: <1392225662-20431-1-git-send-email-thomas.petazzoni@free-electrons.com>
On Wed, Feb 12, 2014 at 06:20:55PM +0100, Thomas Petazzoni wrote:
> Hello,
>
> This series of patches enable audio support on the Marvell Armada 370
> Development Board. Since both the I2S controller on the SoC side and
> the I2C audio codec are already supported by the kernel, the amount of
> work is fairly limited.
>
> Changes since v1:
>
> * Drop patches "sound: codec: add Device Tree binding to cs42l51" and
> " sound: soc: enable Kirkwood driver for mvebu platforms" since
> they have been applied by Mark Brown.
>
> * Set DAI format directly in the snd_soc_dai_link structure instead
> of separately calling snd_soc_dai_set_fmt(). Suggested by Mark
> Brown.
>
> * Do not call snd_soc_dapm_enable_pin(), as Mark Brown mentionned
> that DAPM widgets default to enabled. It allowed to entirely remove
> the dai_init operation.
>
> * Use devm_snd_soc_register_card() instead of
> snd_soc_register_card(), as suggested by Mark Brown.
>
> * Wrote a Device Tree binding document for the DT binding introduced
> by this driver. Requested by Mark Brown.
>
> * Use the DT to look up the controller and the codec, as suggested by
> Mark Brown.
>
> * Add S/PDIF support, which has been successfully tested. I've kept
> it as separate patches (for both the ASoC machine driver, and the
> Device Tree bits), so that it can be reviewed and applied
> separately.
>
> * Modified the commit title so that they contain "ASoC", as requested
> by Mark Brown.
>
> Patches 1 and 2 are to be reviewed/applied by the ASoC maintainer Mark
> Brown, while patches 3 to 7 are to be reviewed/applied by the ARM
> mvebu maintainers.
>
> Note that the audio support for Armada 370 also needs a fix to the
> CS42L51, which is being discussed with the author of the change that
> apparently introduced the problem (see discussion at
> http://mailman.alsa-project.org/pipermail/alsa-devel/2014-January/071916.html).
>
> Thanks,
>
> Thomas
>
> Thomas Petazzoni (7):
> sound: ASoC: add ASoC board driver for Armada 370 DB
> sound: ASoC: add S/PDIF support to Armada 370 DB ASoC driver
> ARM: mvebu: add audio I2S controller to Armada 370 Device Tree
> ARM: mvebu: add I2C0 muxing option for Armada 370 SoC
> ARM: mvebu: add audio support to Armada 370 DB
> ARM: mvebu: enable S/PDIF audio in Armada 370 DB Device Tree
> ARM: mvebu: enable audio options in mvebu_defconfig
>
> .../bindings/sound/armada-370db-audio.txt | 27 ++++
> arch/arm/boot/dts/armada-370-db.dts | 56 ++++++++
> arch/arm/boot/dts/armada-370.dtsi | 28 ++++
> arch/arm/configs/mvebu_defconfig | 5 +
> sound/soc/kirkwood/Kconfig | 9 ++
> sound/soc/kirkwood/Makefile | 2 +
> sound/soc/kirkwood/armada-370-db.c | 148 +++++++++++++++++++++
> 7 files changed, 275 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sound/armada-370db-audio.txt
> create mode 100644 sound/soc/kirkwood/armada-370-db.c
Patches 3 to 6 applied to mvebu/dt. Patch 7 applied to mvebu/defconfig
thx,
Jason.
prev parent reply other threads:[~2014-02-17 2:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-12 17:20 [PATCH v2 0/7] Audio support for Armada 370 DB Thomas Petazzoni
2014-02-12 17:20 ` [PATCH v2 1/7] sound: ASoC: add ASoC board driver " Thomas Petazzoni
2014-02-14 20:36 ` Mark Brown
2014-02-12 17:20 ` [PATCH v2 2/7] sound: ASoC: add S/PDIF support to Armada 370 DB ASoC driver Thomas Petazzoni
2014-03-18 18:38 ` Mark Brown
2014-02-12 17:20 ` [PATCH v2 3/7] ARM: mvebu: add audio I2S controller to Armada 370 Device Tree Thomas Petazzoni
2014-02-12 17:20 ` [PATCH v2 4/7] ARM: mvebu: add I2C0 muxing option for Armada 370 SoC Thomas Petazzoni
2014-02-12 17:21 ` [PATCH v2 5/7] ARM: mvebu: add audio support to Armada 370 DB Thomas Petazzoni
2014-02-12 17:21 ` [PATCH v2 6/7] ARM: mvebu: enable S/PDIF audio in Armada 370 DB Device Tree Thomas Petazzoni
2014-02-12 17:21 ` [PATCH v2 7/7] ARM: mvebu: enable audio options in mvebu_defconfig Thomas Petazzoni
2014-02-17 2:46 ` Jason Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140217024638.GH7862@titan.lakedaemon.net \
--to=jason@lakedaemon.net \
--cc=alior@marvell.com \
--cc=alsa-devel@alsa-project.org \
--cc=andrew@lunn.ch \
--cc=broonie@kernel.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=gregory.clement@free-electrons.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tawfik@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox