From: Mark Brown <broonie@kernel.org>
To: xiangxiao <xiaoxiang@xiaomi.com>
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com
Subject: Re: [PATCH] ASoC: pass snd_soc_jack_gpio to jack_status_check callback
Date: Tue, 18 Feb 2014 10:16:52 +0900 [thread overview]
Message-ID: <20140218011652.GP2669@sirena.org.uk> (raw)
In-Reply-To: <1392528972-9440-1-git-send-email-xiaoxiang@xiaomi.com>
[-- Attachment #1.1: Type: text/plain, Size: 615 bytes --]
On Sun, Feb 16, 2014 at 01:36:12PM +0800, xiangxiao wrote:
> so the implementation could get the context data
>
> Change-Id: I5542613ccf9881deb672e71d0f0c4f603ad761fd
This shouldn't be on upstream patches.
> Signed-off-by: xiangxiao <xiaoxiang@xiaomi.com>
> - int (*jack_status_check)(void);
> + int (*jack_status_check)(struct snd_soc_jack_gpio *gpio);
Why is the callback using details of the implementation of
snd_soc_jack_gpio? Perhaps there's a good reason, I'm not sure and
you've not included any implementation. I'd have expected to see the
jack able to provide its own context here?
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2014-02-18 1:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-16 5:36 [PATCH] ASoC: pass snd_soc_jack_gpio to jack_status_check callback xiangxiao
2014-02-18 1:16 ` Mark Brown [this message]
[not found] ` <C5331076FE79984AAD7207DE353CEA4E40858C60@ex-mbox1.xiaomi.net>
2014-02-22 3:21 ` 答复: " Mark Brown
2014-02-23 6:04 ` 答复: " 肖翔
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140218011652.GP2669@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=xiaoxiang@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox