From: Mark Brown <broonie@kernel.org>
To: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Cc: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/6] ASoC: Intel: Add support for Haswell/Broadwell DSP
Date: Fri, 21 Feb 2014 14:01:21 +0900 [thread overview]
Message-ID: <20140221050121.GA25940@sirena.org.uk> (raw)
In-Reply-To: <1392932927-9725-1-git-send-email-liam.r.girdwood@linux.intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 764 bytes --]
On Thu, Feb 20, 2014 at 09:48:42PM +0000, Liam Girdwood wrote:
> Add support for low level differentiation functions for Haswell and Broadwell
> SST DSPs. This includes suppoprt for DSP boot and reset, DSP firmware module
> parsing and DSP memory block map initialisation.
Applied, thanks. Some terribly minor things below:
> +u32 sst_shim32_read(void __iomem *addr, u32 offset)
> +{
> + return readl(addr + offset);
> +}
> +EXPORT_SYMBOL_GPL(sst_shim32_read);
This lot all look like a regmap to me, though some extensions may be
needed for the 64 bit variants!
> +struct sst_ops haswell_ops = {
> + .reset = hsw_reset,
> + .boot = hsw_boot,
> + .write = sst_shim32_write,
Something appears funky with the indentation for .boot - tab/space
confusion?
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2014-02-21 6:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 21:48 [PATCH 1/6] ASoC: Intel: Add support for Haswell/Broadwell DSP Liam Girdwood
2014-02-20 21:48 ` [PATCH 2/6] ASoC: Intel: Add Haswell/Broadwell IPC Liam Girdwood
2014-02-21 5:03 ` Mark Brown
2014-02-20 21:48 ` [PATCH 3/6] ASoC: Intel: Add Haswell and Broadwell PCM platform driver Liam Girdwood
2014-02-21 5:16 ` Mark Brown
2014-02-21 7:11 ` Takashi Iwai
2014-02-23 3:19 ` Mark Brown
2014-02-24 20:00 ` Liam Girdwood
2014-02-21 7:28 ` Takashi Iwai
2014-02-24 20:07 ` Liam Girdwood
2014-02-20 21:48 ` [PATCH 4/6] ASoC: Intel: Add trace support for Haswell/Broadwell SST IPC messages Liam Girdwood
2014-02-21 5:19 ` Mark Brown
2014-02-24 19:50 ` Liam Girdwood
2014-02-20 21:48 ` [PATCH 5/6] ASoC: Intel: Add build support for Haswell ADSP Liam Girdwood
2014-02-21 5:19 ` Mark Brown
2014-02-20 21:48 ` [PATCH 6/6] ASoC: Intel: Add Haswell Machine support Liam Girdwood
2014-02-21 5:22 ` Mark Brown
2014-02-24 19:55 ` Liam Girdwood
2014-02-21 5:01 ` Mark Brown [this message]
2014-02-21 13:05 ` [PATCH 1/6] ASoC: Intel: Add support for Haswell/Broadwell DSP Jarkko Nikula
2014-02-24 20:09 ` Liam Girdwood
2014-02-24 19:47 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140221050121.GA25940@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox