From: Mark Brown <broonie@kernel.org>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc: Liam Girdwood <liam.r.girdwood@linux.intel.com>,
alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH 5/7] ASoC: Intel: Add machine driver for Baytrail SST with RT5640 codec
Date: Tue, 25 Feb 2014 13:42:06 +0900 [thread overview]
Message-ID: <20140225044206.GW25940@sirena.org.uk> (raw)
In-Reply-To: <1393255622-31365-6-git-send-email-jarkko.nikula@linux.intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 714 bytes --]
On Mon, Feb 24, 2014 at 05:27:00PM +0200, Jarkko Nikula wrote:
> +static const struct snd_kcontrol_new byt_rt5640_controls[] = {
> + SOC_DAPM_PIN_SWITCH("Headphone"),
> + SOC_DAPM_PIN_SWITCH("Headset Mic"),
> + SOC_DAPM_PIN_SWITCH("Int Mic"),
> + SOC_DAPM_PIN_SWITCH("Ext Spk"),
Is this really an external speaker (you're making this visible as a
control name...)?
> + fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF |
> + SND_SOC_DAIFMT_CBS_CFS;
> +
> + ret = snd_soc_dai_set_fmt(codec_dai, fmt);
> + if (ret < 0) {
> + dev_err(codec_dai->dev,
> + "can't set codec DAI configuration %d\n", ret);
> + return ret;
> + }
Set this in the dai_link like with the other Intel machine driver the
other day.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2014-02-25 4:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 15:26 [PATCH 0/7] ASoC: Intel: Add support for Baytrail SST DSP Jarkko Nikula
2014-02-24 15:26 ` [PATCH 1/7] ASoC: Intel: Add Baytrail SST ID and Baytrail specific register bits Jarkko Nikula
2014-02-24 15:26 ` [PATCH 2/7] ASoC: Intel: Add Intel Baytrail SST DSP support Jarkko Nikula
2014-02-24 15:26 ` [PATCH 3/7] ASoC: Intel: Add Intel Baytrail SST DSP IPC support Jarkko Nikula
2014-02-24 15:26 ` [PATCH 4/7] ASoC: Intel: Add Intel Baytrail SST PCM platform driver Jarkko Nikula
2014-02-24 15:27 ` [PATCH 5/7] ASoC: Intel: Add machine driver for Baytrail SST with RT5640 codec Jarkko Nikula
2014-02-25 4:42 ` Mark Brown [this message]
2014-02-24 15:27 ` [PATCH 6/7] ASoC: Intel: Add Baytrail SST and byt-rt5640 machine driver probing Jarkko Nikula
2014-02-24 15:27 ` [PATCH 7/7] ASoC: Intel: Add build support for Baytrail SST Jarkko Nikula
2014-02-24 20:16 ` [PATCH 0/7] ASoC: Intel: Add support for Baytrail SST DSP Liam Girdwood
2014-02-25 4:44 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140225044206.GW25940@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=liam.r.girdwood@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox