Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: liam.r.girdwood@linux.intel.com
Cc: alsa-devel@alsa-project.org
Subject: Re: ASoC: Intel: Add Haswell/Broadwell IPC
Date: Tue, 25 Feb 2014 11:34:32 +0300	[thread overview]
Message-ID: <20140225083432.GA5023@elgon.mountain> (raw)

Hello Liam Girdwood,

The patch 22981243589c: "ASoC: Intel: Add Haswell/Broadwell IPC" from
Feb 20, 2014, leads to the following imaginary static checker warning:

	sound/soc/intel/sst-haswell-ipc.c:898 hsw_irq_thread()
	warn: this is always true.

sound/soc/intel/sst-haswell-ipc.c
   895                  /* Handle Immediate reply from DSP Core */
   896                  handled = hsw_process_reply(hsw, ipcx);
                                  ^^^^^^^^^^^^^^^^^
Returns 1 on success/error and -EIO on error.

   897  
   898                  if (handled) {
   899                          /* clear DONE bit - tell DSP we have completed */
   900                          sst_dsp_shim_update_bits_unlocked(sst, SST_IPCX,
   901                                  SST_IPCX_DONE, 0);
   902  
   903                          /* unmask Done interrupt */
   904                          sst_dsp_shim_update_bits_unlocked(sst, SST_IMRX,
   905                                  SST_IMRX_DONE, 0);
   906                  }

regards,
dan carpenter

                 reply	other threads:[~2014-02-25  8:34 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140225083432.GA5023@elgon.mountain \
    --to=dan.carpenter@oracle.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=liam.r.girdwood@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox