Re: [PATCH] ASoC: da732x: Mark DC offset control registers volatile

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1036 bytes --]

On Tue, Feb 25, 2014 at 04:13:02PM +0000, Opensource [Adam Thomson] wrote:
> On Tue, 25 Feb 2014 01:22:04 +0000, Mark Brown wrote:

> > Refactoring the offset correction to happen once on startup would solve
> > the issue since the cache could just be bypassed, though you are likely
> > to find that there is some run to run variation for the callibration due
> > to effects like thermal variation and simple measurement errors.  Still,
> > the effects are typically very small.

> I have to agree, the variation won't be great. If it were then you'd see
> problems for example when keeping a device awake for prolonged periods and
> during fluctuations in temperature. As far as I'm aware issues like this have
> not been experienced with this device so I think it's safe to make this a one
> time thing at startup.

OK, so in that case how about applying the patch I sent for now (since
it should make things better for stable users) and then refactoring to
do the callibration at startup with cache bypass enabled for a proper
fix?

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]