From: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
To: vinod.koul@intel.com
Cc: ckeepax@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org,
elaurent@google.com
Subject: [TINYCOMPRESS][PATCH 1/1] compress: no need to set metadata before calling next_track
Date: Wed, 26 Feb 2014 14:29:28 +0000 [thread overview]
Message-ID: <20140226142829.GB2002@opensource.wolfsonmicro.com> (raw)
The metadata is mainly for MP3 gapless playback, since
the MP3 audio stream does not contain enough information
to enable gapless. Other audio formats do not necessarily
require any additional metadata so we should allow next_track
to be called without any metadata.
Signed-off-by: Zhao Weijia <weijia.zhao@capelabs.com>
Signed-off-by: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
---
compress.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/compress.c b/compress.c
index 15dfdb7..0c9ecd2 100644
--- a/compress.c
+++ b/compress.c
@@ -534,8 +534,6 @@ int compress_next_track(struct compress *compress)
if (!is_compress_running(compress))
return oops(compress, ENODEV, "device not ready");
- if (!compress->gapless_metadata)
- return oops(compress, EPERM, "metadata not set");
if (ioctl(compress->fd, SNDRV_COMPRESS_NEXT_TRACK))
return oops(compress, errno, "cannot set next track\n");
compress->next_track = 1;
--
1.7.2.5
next reply other threads:[~2014-02-26 14:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 14:29 Richard Fitzgerald [this message]
2014-02-27 16:07 ` [TINYCOMPRESS][PATCH 1/1] compress: no need to set metadata before calling next_track Pierre-Louis Bossart
2014-03-03 13:25 ` Richard Fitzgerald
2014-03-03 14:57 ` Pierre-Louis Bossart
2014-03-03 16:36 ` Richard Fitzgerald
2014-03-03 19:40 ` Pierre-Louis Bossart
2014-03-06 10:32 ` Richard Fitzgerald
2014-03-07 14:32 ` Richard Fitzgerald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140226142829.GB2002@opensource.wolfsonmicro.com \
--to=rf@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=elaurent@google.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox