From: Mark Brown <broonie@kernel.org>
To: Xiubo Li <Li.Xiubo@freescale.com>
Cc: lgirdwood@gmail.com, vinod.koul@intel.com,
brian.austin@cirrus.com, Paul.Handrigan@cirrus.com,
timur@tabi.org, mr.swami.reddy@ti.com,
vishwas.a.deshpande@ti.com, fabio.estevam@freescale.com,
kuninori.morimoto.gx@renesas.com, sachin.kamat@linaro.org,
Adam.Thomson.Opensource@diasemi.com, dgreid@chromium.org,
abrestic@chromium.org, swarren@nvidia.com, shc_work@mail.ru,
s.trumtrar@pengutronix.de, bardliao@realtek.com,
shawn.guo@linaro.org, LW@KARO-electronics.de, mpa@pengutronix.de,
peter.ujfalusi@ti.com, Andreas.Irestal@axis.com,
ckeepax@opensource.wolfsonmicro.com,
rf@opensource.wolfsonmicro.com, viresh.kumar@linaro.org,
axel.lin@ingics.com, alban.bedel@avionic-design.de,
voice.shen@atmel.com, jic23@kernel.org, mahaijuns@gmail.com,
mike.dyer@md-soft.co.uk, b42378@freescale.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: io: Clean up snd_soc_codec_set_cache_io()
Date: Thu, 27 Feb 2014 13:11:40 +0900 [thread overview]
Message-ID: <20140227041140.GC9383@sirena.org.uk> (raw)
In-Reply-To: <1393465065-9512-1-git-send-email-Li.Xiubo@freescale.com>
[-- Attachment #1: Type: text/plain, Size: 765 bytes --]
On Thu, Feb 27, 2014 at 09:37:45AM +0800, Xiubo Li wrote:
> I'm also thinking could we just discard snd_soc_codec_set_cache_io()
> calling from each individual driver to simply the code? And just bind
> it to devm_regmap_init_i2c() and devm_regmap_init_spi()...
> Is there any other limitations for snd_soc_codec_set_cache_io() usage?
That's the goal overall, I'm not sure it's worth going through and
changing the signature of the function and then later going through and
merging it, it's just too much churn. The main thing we need to do in
order to do that is to make sure nothing is relying on specific
sequencing during startup, probably by providing a way to manually set
the regmap pointer in the main device probe function rather than in the
ASoC one.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-02-27 4:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 1:37 [PATCH] ASoC: io: Clean up snd_soc_codec_set_cache_io() Xiubo Li
2014-02-27 4:11 ` Mark Brown [this message]
2014-02-27 10:18 ` Li.Xiubo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140227041140.GC9383@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=Andreas.Irestal@axis.com \
--cc=LW@KARO-electronics.de \
--cc=Li.Xiubo@freescale.com \
--cc=Paul.Handrigan@cirrus.com \
--cc=abrestic@chromium.org \
--cc=alban.bedel@avionic-design.de \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@ingics.com \
--cc=b42378@freescale.com \
--cc=bardliao@realtek.com \
--cc=brian.austin@cirrus.com \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=dgreid@chromium.org \
--cc=fabio.estevam@freescale.com \
--cc=jic23@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mahaijuns@gmail.com \
--cc=mike.dyer@md-soft.co.uk \
--cc=mpa@pengutronix.de \
--cc=mr.swami.reddy@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=rf@opensource.wolfsonmicro.com \
--cc=s.trumtrar@pengutronix.de \
--cc=sachin.kamat@linaro.org \
--cc=shawn.guo@linaro.org \
--cc=shc_work@mail.ru \
--cc=swarren@nvidia.com \
--cc=timur@tabi.org \
--cc=vinod.koul@intel.com \
--cc=viresh.kumar@linaro.org \
--cc=vishwas.a.deshpande@ti.com \
--cc=voice.shen@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox