Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] ASoC: wm8753: Remove superfluous 'codec->cache_sync =	1'
Date: Mon, 3 Mar 2014 09:09:17 +0000	[thread overview]
Message-ID: <20140303090917.GG8570@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1393678004-17427-1-git-send-email-lars@metafoo.de>

On Sat, Mar 01, 2014 at 01:46:44PM +0100, Lars-Peter Clausen wrote:
> The wm8763 driver uses regmap for IO which means that codec->cache_sync is not
> used. The line was added in commit d3398ff ('ASoC: Convert WM8753 to direct
> regmap API usage'). Presumably this was meant to be regcache_mark_dirty(), but
> since we already call regcache_mark_dirty() in the core when suspending the
> CODEC it is safe to just remove the line.
> 
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> ---

Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>

Thanks,
Charles

  reply	other threads:[~2014-03-03  9:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-01 12:46 [PATCH] ASoC: wm8753: Remove superfluous 'codec->cache_sync = 1' Lars-Peter Clausen
2014-03-03  9:09 ` Charles Keepax [this message]
2014-03-04  4:04 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140303090917.GG8570@opensource.wolfsonmicro.com \
    --to=ckeepax@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lars@metafoo.de \
    --cc=lgirdwood@gmail.com \
    --cc=patches@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox