From: Mark Brown <broonie@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: alsa-devel@alsa-project.org, linaro-kernel@lists.linaro.org,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] ASoC: io: Remove hw_read() operation
Date: Tue, 4 Mar 2014 17:27:23 +0800 [thread overview]
Message-ID: <20140304092723.GH13126@sirena.org.uk> (raw)
In-Reply-To: <53159AD0.5000800@metafoo.de>
[-- Attachment #1.1: Type: text/plain, Size: 773 bytes --]
On Tue, Mar 04, 2014 at 10:20:16AM +0100, Lars-Peter Clausen wrote:
> > codec->write = hw_write;
> >- codec->read = hw_read;
> But this part will break snd_soc_read() and with it basically every
> driver that has any controls or DAPM widgets.
Bah, so it does.
> I do have a set of patches that moves IO to the component level that
> will clean this all up quite a bit. I'm just waiting for Xiubo Li
> snd_soc_codec_set_cache_io() cleanup to be merged first, since it
> will make things a bit simpler.
That seems to be going really slowly... in any case the real fix here
is to get all the users converted over to regmap. We could also just
do something similar to what we've done with update_bits() (where we did
it for locking) which is going to be much quicker.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2014-03-04 9:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 9:10 [PATCH] ASoC: io: Remove hw_read() operation Mark Brown
2014-03-04 9:20 ` Lars-Peter Clausen
2014-03-04 9:27 ` Mark Brown [this message]
2014-03-04 9:45 ` Lars-Peter Clausen
2014-03-04 10:11 ` Mark Brown
2014-03-04 11:25 ` Lars-Peter Clausen
2014-03-05 1:25 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140304092723.GH13126@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linaro-kernel@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox